Fixed two bugs with handling of the replacement character + tests#74
Open
raydog wants to merge 1 commit intododo:masterfrom
Open
Fixed two bugs with handling of the replacement character + tests#74raydog wants to merge 1 commit intododo:masterfrom
raydog wants to merge 1 commit intododo:masterfrom
Conversation
|
I added your test for multiple leading and trailing separators in my fork here: larvit@e1500dd But since I rewrote the base code quite a bit for a lot of reasons, I made it an option to remove multiple whitespaces. That collides with hard coding something that removes multiple instances of the replace character as well... I have no pretty solution for this, do you? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes two bugs I found while reading the source code:
This is similar to PR #55, except that this code escapes the separator, so it should still work when the replacement character is a regexp character.