Fixes while implementing filesystem for ESnet endpoint#39
Merged
gabor-lbl merged 4 commits intodoe-iri:mainfrom Feb 20, 2026
Merged
Fixes while implementing filesystem for ESnet endpoint#39gabor-lbl merged 4 commits intodoe-iri:mainfrom
gabor-lbl merged 4 commits intodoe-iri:mainfrom
Conversation
- Deterministic uuid in demo adapter; - Allow DEMO_QUEUE_UPDATE_SECS change via env variable; - Fix Auth schemantics. Check api_key if Bearer used. extract it (only demo_adapter.py) - Fix filesystem api: use skip_heading for tail; define all return models for all filesystem calls; Nested results. use jsonable_encoder to parse it. - Break extract in demo_adapter if dir is present. - Catch project None; - JobStates use enum. Cleaner schema. no custom serializer. (fails schema validation run output != documented contract)
gabor-lbl
reviewed
Feb 18, 2026
| raise HTTPException(status_code=400, detail="Cannot delete sandbox") | ||
| subprocess.run(["rm", "-rf", rp], check=True) | ||
| return None | ||
| return filesystem_models.RemoveResponse(output=f"Removed {rp}") |
Contributor
There was a problem hiding this comment.
Why is this needed? If rm fails you already get an error. What additional benefit do we get from returning a static string? Same comment for put files.
Contributor
Author
There was a problem hiding this comment.
It is not required, but I find it useful to have a structured format returned for all Filesystem APIs (It keeps results structured). While it makes sense in synchronous calls to return 204, maybe results could be:
{ "path": "/foo", "deleted": true }
Contributor
There was a problem hiding this comment.
Ok I see - yes for async calls we do need something. Thanks!
- upgrade humps to pyhumps 3.8.0 (support not only camelize, but also decamelize)
- Add aliasChoices for target/link{Path}. Match source path
- Update test script to choose storage randomly. Test camelCase, snakeCase
Contributor
Author
|
Changed everything to snake_case only. @gabor-lbl, ready for your review |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.