Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR represents a major overhaul of the ASP.NET Core configuration documentation. The changes modernize the content to be more generic and applicable across UI stacks, update cross-references to align with the restructured configuration article, and consolidate versioned include files into more maintainable documentation patterns.
Key Changes
- Updated cross-references throughout documentation to point to new anchor IDs in the restructured configuration article (e.g.,
#boa→#bind-an-array,#kestrel→#kestrel-endpoint-configuration) - Consolidated dependency injection service collection examples into versioned include files
- Enhanced security warnings about connection strings and authentication flows
- Deleted obsolete versioned include files (index6.md, index7.md) and replaced references to combine-di*.md files
Reviewed Changes
Copilot reviewed 26 out of 27 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| aspnetcore/security/key-vault-configuration.md | Updated cross-reference anchor from #boa to #bind-an-array |
| aspnetcore/security/app-secrets/includes/app-secrets-3-5.md | Updated cross-reference anchor from #boa to #bind-an-array |
| aspnetcore/security/app-secrets.md | Updated cross-reference anchor from #boa to #bind-an-array |
| aspnetcore/includes/managed-identities-conn-strings.md | Enhanced security warning text about connection strings and authentication |
| aspnetcore/includes/environmentVarableColon.md | Minor grammar and formatting improvements for environment variable separator documentation |
| aspnetcore/includes/combine-service-collection-60-or-later.md | New include file containing service collection examples for .NET 6.0+ |
| aspnetcore/includes/combine-service-collection-31-to-60.md | New include file containing service collection examples for .NET 3.1-6.0 |
| aspnetcore/includes/combine-di6.md | Deleted obsolete include file |
| aspnetcore/includes/combine-di.md | Deleted obsolete include file |
| aspnetcore/host-and-deploy/azure-apps/index.md | Simplified Azure Portal configuration section with updated cross-reference |
| aspnetcore/fundamentals/minimal-apis/includes/webapplication*.md | Updated Kestrel endpoint configuration cross-references across multiple version files |
| aspnetcore/fundamentals/index/includes/index*.md | Updated configuration cross-references in fundamentals documentation |
| aspnetcore/fundamentals/index.md | Updated cross-reference anchor from #default to #default-app-configuration-sources |
| aspnetcore/fundamentals/host/generic-host.md | Updated cross-reference anchor from #default to #default-app-configuration-sources |
| aspnetcore/fundamentals/dependency-injection/includes/dependency-injection-*.md | Replaced references to obsolete combine-di*.md files with versioned includes |
| aspnetcore/fundamentals/dependency-injection.md | Replaced reference to obsolete combine-di6.md file |
| aspnetcore/fundamentals/configuration/options/includes/options6.md | Expanded inline content replacing bind6.md include with full options pattern documentation |
| aspnetcore/fundamentals/configuration/options.md | Expanded inline content replacing bind7.md include with full options pattern documentation |
| aspnetcore/fundamentals/configuration/index/includes/index7.md | Deleted obsolete versioned include file |
| aspnetcore/fundamentals/configuration/index/includes/index6.md | Deleted obsolete versioned include file |
| aspnetcore/fundamentals/configuration/index/includes/index3-5.md | Deleted obsolete versioned include file |
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
|
@tdykstra ... Same deal here. This has been sitting forever, and it's probably going to break badly when new work finally hits one or more of these articles. I suggest that we go ahead and get it reviewed and merged when you're free. |
This comment was marked as resolved.
This comment was marked as resolved.
Co-authored-by: Tom Dykstra <tdykstra@microsoft.com>
|
Thanks for these reviews, @tdykstra! I've been worried about merge conflicts badly breaking them. I'll do a final clean-up commit on this before merging it. |
…dotnet/AspNetCore.Docs into guardrex/configuration-overhaul
Fixes #35803
Fixes #30088
Fixes #27620
NOTES
Outline:
ProgramfileStartupclassappsettings.json,appsettings.{ENVIRONMENT}.json)GetValue)GetSectionGetChildrenandExistsInternal previews