use _value instead of ToString in SqlConnectionEncryptOption#4013
Open
SimonCropp wants to merge 1 commit intodotnet:mainfrom
Open
use _value instead of ToString in SqlConnectionEncryptOption#4013SimonCropp wants to merge 1 commit intodotnet:mainfrom
SimonCropp wants to merge 1 commit intodotnet:mainfrom
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR is a minor performance/quality improvement to SqlConnectionEncryptOption. The Equals and GetHashCode overrides previously called ToString() and then compared/hashed the returned string. Since ToString() simply returns the private _value field, the PR replaces those indirect calls with direct access to _value, eliminating two unnecessary virtual method dispatches.
Changes:
Equals(object)now compares_valuedirectly instead of going throughToString().GetHashCode()now hashes_valuedirectly instead of going throughToString().
paulmedynski
added
the
Code Health 💊
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.