Add AvdManagerRunner for avdmanager CLI operations

[rmarinho]

Summary

Wraps avdmanager CLI operations for programmatic AVD management. Addresses #277.

API Surface

public class AvdManagerRunner
{
    // Constructor takes a resolved avdmanager path + optional environment variables
    public AvdManagerRunner(string avdManagerPath, IDictionary<string, string>? environmentVariables = null);

    // List all configured AVDs
    public async Task<IReadOnlyList<AvdInfo>> ListAvdsAsync(CancellationToken ct = default);

    // Create an AVD with the given name and system image
    public async Task CreateAvdAsync(string name, string systemImage, string? deviceProfile = null,
        bool force = false, CancellationToken ct = default);

    // Delete an AVD by name
    public async Task DeleteAvdAsync(string name, CancellationToken ct = default);

    // Get the AVD root directory
    public string GetAvdRootDirectory();

    // Static parser for avdmanager list avd output
    public static List<AvdInfo> ParseAvdListOutput(string output);
}

public record AvdInfo
{
    public required string Name { get; init; }
    public string? DeviceProfile { get; init; }
    public string? Path { get; init; }
}

Key Design Decisions

• Resolved path constructor: Takes string avdManagerPath (full path to avdmanager binary) instead of Func<string?>. Callers resolve the path before constructing the runner. Follows the same pattern as AdbRunner (Add AdbRunner for adb CLI operations #283).
• Environment variables via dictionary: IDictionary<string, string>? environmentVariables passed to ProcessUtils.StartProcess for ANDROID_HOME/JAVA_HOME/PATH configuration. Avoids internal PSI manipulation.
• ThrowIfFailed with StringWriter overload: Uses ProcessUtils.ThrowIfFailed(exitCode, command, stderr) directly with StringWriter parameters — no .ToString() at call sites.
• Pattern matching for null checks: Uses is { Length: > 0 } instead of !string.IsNullOrEmpty() — consistent with codebase conventions and avoids netstandard2.0 nullable narrowing issues.
• ProcessUtils.FindCmdlineTool: Static helper that searches cmdline-tools/{version}/bin/ (highest version first), then latest, then legacy tools/bin/. Consumers call this to resolve the avdmanager path before constructing the runner.
• ProcessUtils.ValidateNotNullOrEmpty: Shared validation helper for constructor/method parameter checks.

Tests

• 17 tests: parsing (2), validation (7), directory search (4), environment variable handling (4)
• FindCmdlineTool_FindsVersionedDir, _PrefersHigherVersion, _FallsBackToLatest, _MissingSdk_ReturnsNull — test path resolution
• Constructor_NullPath_ThrowsArgumentException, Constructor_EmptyPath_ThrowsArgumentException — constructor validation
• CreateAvdAsync_*, DeleteAvdAsync_* — argument validation

Commits

SHA	Description
271b5c1	Use shared helpers in AvdManagerRunner
37c3a79	Address PR review feedback: exit codes, type splitting, structured args
d96296a	Refactor constructor to resolved path, pattern matching, ThrowIfFailed overload

[Copilot]

Pull request overview

Adds a new “runner” layer to Xamarin.Android.Tools.AndroidSdk to execute Android SDK command-line tools programmatically, with an initial AvdManagerRunner implementation for creating/listing/deleting AVDs.

Changes:

• Introduces AndroidToolRunner for running SDK tools with timeout/stdout/stderr capture (sync + async) and a background-start helper.
• Adds AvdManagerRunner to locate and invoke avdmanager, parse list avd output, and enrich results from config.ini.
• Adds supporting models (ToolRunnerResult, AvdInfo) and environment setup utilities (AndroidEnvironmentHelper).

Reviewed changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated 8 comments.

Show a summary per file

File	Description
src/Xamarin.Android.Tools.AndroidSdk/Runners/AvdManagerRunner.cs	Adds an avdmanager wrapper with list/create/delete and output parsing/enrichment.
src/Xamarin.Android.Tools.AndroidSdk/Runners/AndroidToolRunner.cs	Adds process execution utilities (sync/async + background start).
src/Xamarin.Android.Tools.AndroidSdk/Runners/AndroidEnvironmentHelper.cs	Provides JAVA_HOME / ANDROID_HOME setup plus ABI/API/tag mapping helpers.
src/Xamarin.Android.Tools.AndroidSdk/Models/ToolRunnerResult.cs	Introduces a result type for tool execution (typed + untyped).
src/Xamarin.Android.Tools.AndroidSdk/Models/AvdInfo.cs	Adds an AVD info model used by AvdManagerRunner.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[jonathanpeppers]

I'd like to get the System.Diagnostics.Process code unified like mentioned here:

• Add base Android tool runner infrastructure #281 (comment)

[Copilot]

Pull request overview

Copilot reviewed 3 out of 3 changed files in this pull request and generated 12 comments.

[Copilot]

Pull request overview

Copilot reviewed 4 out of 4 changed files in this pull request and generated 5 comments.

[Copilot]

CreateAvdAsync hard-codes the AVD directory as $HOME/.android/avd/<name>.avd for orphan detection and for the returned AvdInfo.Path. avdmanager can place AVDs elsewhere when ANDROID_USER_HOME/ANDROID_AVD_HOME are set, so this can incorrectly force --force and/or return the wrong path. Consider deriving the AVD location from the tool output (or re-list after creation and return the matching entry) and basing orphan detection on the same resolved location/env vars.

[Copilot]

DeleteAvdAsync doesn't validate name (null/empty/whitespace). Passing an empty name will invoke avdmanager with an invalid --name value and can lead to confusing errors; please add the same argument validation used in CreateAvdAsync.

[jonathanpeppers]

🤖 AI Review Summary

Found 5 issues: 1 security concern, 1 error handling gap, 1 consistency gap, 1 missing constant, 1 convention violation.

• Security / API design: additionalArgs as single string risks injection and breaks multi-arg callers (EmulatorRunner.cs:57)
• Error handling: Bare catch block silently swallows exceptions (AdbRunner.cs:106)
• Consistency: Exit code not checked in ListDevicesAsync / ListAvdNamesAsync while other methods do (AdbRunner.cs:71)
• Naming: Raw "ANDROID_AVD_HOME" string instead of EnvironmentVariableNames constant (AvdManagerRunner.cs:212)
• Code organization: Three types in one file (AdbDeviceInfo.cs)

👍 Excellent test coverage with thorough parsing tests. Good CancellationToken propagation throughout, correct OperationCanceledException rethrow. AndroidEnvironmentHelper is a clean factoring of shared env setup. Orphaned AVD detection in CreateAvdAsync is a smart touch.

---

Review generated by android-tools-reviewer from review guidelines by @jonathanpeppers.