[tests] Clear ResolvedCodeAnalysisRuleSet to fix CoreCompile incrementality on CI#10900
Open
jonathanpeppers wants to merge 1 commit intomainfrom
Open
[tests] Clear ResolvedCodeAnalysisRuleSet to fix CoreCompile incrementality on CI#10900jonathanpeppers wants to merge 1 commit intomainfrom
jonathanpeppers wants to merge 1 commit intomainfrom
Conversation
…tality on CI CI Guardian SDL analysis (MergeGuardianDotnetAnalyzersRuleSets) regenerates a merged .ruleset file on every build with a new timestamp. Since is in CoreCompile's Inputs, this causes CoreCompile to re-run even when no source files changed, cascading through ILLink -> _GenerateJavaStubs -> _Sign and breaking incrementality tests: - BasicApplicationRepetitiveReleaseBuild - CheckTimestamps - GenerateJavaStubsAndAssembly
jonathanpeppers
requested review from
grendello and
simonrozsival
as code owners
Member
Author
|
This might be happening on main/trusted builds only, running a build here: |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR addresses a CI flakiness issue where the Guardian SDL analysis tool (MergeGuardianDotnetAnalyzersRuleSets) regenerates a merged .ruleset file with a new timestamp on every build. Since this file path is passed to CoreCompile via $(ResolvedCodeAnalysisRuleSet), MSBuild considers the inputs stale and re-runs CoreCompile unnecessarily, cascading through subsequent targets (ILLink, _GenerateJavaStubs, _Sign) and breaking incrementality tests.
Changes:
- Adds an MSBuild target
_ClearResolvedCodeAnalysisRuleSettoDirectory.Build.targetsin the test project template that clears$(ResolvedCodeAnalysisRuleSet)just beforeCoreCompileruns, restoring correct incremental build behavior on CI.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CI Guardian SDL analysis (MergeGuardianDotnetAnalyzersRuleSets) regenerates a merged .ruleset file on every build with a new timestamp. Since it is in CoreCompile's Inputs, this causes CoreCompile to re-run even when no source files changed, cascading through ILLink -> _GenerateJavaStubs -> _Sign and breaking incrementality tests: