Remove redundant column names collection from DataFrameColumnCollection#6701
Remove redundant column names collection from DataFrameColumnCollection#6701michaelgsharp merged 1 commit intodotnet:mainfrom asmirnov82:remove_redundant_name_collection
Conversation
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #6701 +/- ##
=======================================
Coverage ? 68.77%
=======================================
Files ? 1215
Lines ? 251723
Branches ? 26256
=======================================
Hits ? 173132
Misses ? 71773
Partials ? 6818
Flags with carried forward coverage won't be shown. Click here to find out more.
|
|
@asmirnov82 thanks so much for all your contributions to DataFrame. I’m on vacation but I can review in about a week and I’m the resident expert at the moment. Would you be open to porting them to another branch? I have a fairly big PR to modernize DataFrame to .NET 6 and Generic Math. If you could open a PR into that branch also… it would help a bunch. |
|
Hi, @JakeRadMSFT. Many thanks for you quick response. I hope you're having a great time enjoying your vacation! I created PR with porting all my changes to a new logic with general math. I also had to merge the latest main branch from the original machinelearning repo to avoid merging conflicts. You may check, when you have time: https://github.com/JakeRadMSFT/machinelearning/pull/2/commits |
Thanks so much! |
|
/azp run |
|
Azure Pipelines successfully started running 2 pipeline(s). |
|
Merged into Generic Math branch. (This is just a note for myself) |
column names collection was used to get column name by column index. As DataFrameColumnCollection is already collection of columns that can be accessed by index - this[i].Name can be used instead to get name. Storing dedicated collection of names is excessive,