Open
Conversation
Member
Author
Contributor
|
Tagging subscribers to this area: @steveisok, @tommcdon, @dotnet/dotnet-diag |
This was referenced Apr 12, 2026
Member
Member
Author
Member
|
I am not sure which one will go first. If these changes are independent, it would make more sense to submit them as independent PRs. |
ffa8a51 to
695f29e
Compare
This was referenced Apr 13, 2026
Open
jkotas
reviewed
Apr 14, 2026
Member
jkotas
left a comment
There was a problem hiding this comment.
One of the Microsoft maintainers will have to run internal VS debugger tests on this before it gets merged.
...coreclr/System.Private.CoreLib/src/System/Runtime/CompilerServices/RuntimeHelpers.CoreCLR.cs
Outdated
Show resolved
Hide resolved
...coreclr/System.Private.CoreLib/src/System/Runtime/CompilerServices/RuntimeHelpers.CoreCLR.cs
Outdated
Show resolved
Hide resolved
Member
Author
|
Failures are known, the new one is unrelated deadlettered leg. Results still match before/after #126809 (comment) |
Member
|
Let me run the private diagnostic tests with this change. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


Built on top of #126542.Last part of #123864 before the final cleanups.