Fix COM Event ilstub classification#126850
Open
jkoritzinsky wants to merge 1 commit intodotnet:mainfrom
Open
Conversation
The stub was incorrectly classified as a P/Invoke, and we have special handling for P/Invokes for GCStress. Correctly classify the stubs as their own kind of stub (Com events).
Contributor
|
Tagging subscribers to this area: @dotnet/interop-contrib |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes CoreCLR’s IL stub classification for COM event call stubs so they are no longer treated as generic P/Invoke stubs, avoiding GCStress behavior that is specific to P/Invokes and implicated in the COM Interop test crash.
Changes:
- Classify COM event call IL stubs as COM stubs by including
PINVOKESTUB_FL_COMalongsidePINVOKESTUB_FL_COMEVENTCALL. - Add a distinct stub name string for the
StubCLRToCOMEventIL stub type to improve identification/diagnostics.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/coreclr/vm/ilstubcache.cpp | Adds a distinct name mapping for DynamicMethodDesc::StubCLRToCOMEvent so the newly reachable stub type is identifiable. |
| src/coreclr/vm/clrtocomcall.cpp | Fixes the stub flags used when creating COM event call IL stubs so SF_IsCOMStub recognizes them (enabling correct StubCLRToCOMEvent classification). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The stub was incorrectly classified as a P/Invoke, and we have special handling for P/Invokes for GCStress. Correctly classify the stubs as their own kind of stub (Com events).
Fixes #126724