Use DefaultAzureCredential by default (#497)#550
Open
janjagusch wants to merge 1 commit intodrivendataorg:masterfrom
Open
Use DefaultAzureCredential by default (#497)#550janjagusch wants to merge 1 commit intodrivendataorg:masterfrom
janjagusch wants to merge 1 commit intodrivendataorg:masterfrom
Conversation
janjagusch
force-pushed
the
feat/default-azure-credential
branch
2 times, most recently
from
03ea50f to
e23d7e5
Compare
…provided When `account_url` is provided without `credential`, automatically use `DefaultAzureCredential` from `azure-identity` if installed, bringing Azure auth in line with how `GSClient` uses `google.auth.default()`. Also adds support for `AZURE_STORAGE_ACCOUNT_URL` env var as a fallback. Closes drivendataorg#497 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
janjagusch
force-pushed
the
feat/default-azure-credential
branch
from
e23d7e5 to
fafa0b7
Compare
Author
|
@pjbull, hope you don't mind this agent-written PR. I reviewed the changes myself, making sure the diff remains minimal and plausible, and the changes look good to me. :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
account_urlis provided withoutcredential, automatically usesDefaultAzureCredentialfromazure-identityif installed (falls back tocredential=Noneif not installed)AZURE_STORAGE_ACCOUNT_URLenvironment variable as a new fallback before raisingMissingCredentialsError, mirroring the existingAZURE_STORAGE_CONNECTION_STRINGpattern""AZURE_STORAGE_CONNECTION_STRING"andraised raised)Closes #497
Test plan
test_azureblobpath_nocredsupdated to also clearAZURE_STORAGE_ACCOUNT_URLenv varDefaultAzureCredentialused whenaccount_urlprovided withoutcredentialcredentialtakes precedence overDefaultAzureCredentialcredential=Nonewhenazure-identitynot installedAZURE_STORAGE_ACCOUNT_URLenv var with.blob.URLAZURE_STORAGE_ACCOUNT_URLenv var with.dfs.URLMissingCredentialsErrorstill raised with no configtest_azure_specific.pypasstest_local.pypass🤖 Generated with Claude Code