actually install the version that we're saying we're installing#321
Open
jeffory-orrok wants to merge 1 commit intods300:masterfrom
Open
actually install the version that we're saying we're installing#321jeffory-orrok wants to merge 1 commit intods300:masterfrom
jeffory-orrok wants to merge 1 commit intods300:masterfrom
Conversation
Include the package name and version in the `yarn` and `npm install` commands.
Author
|
Sorry, I don't have time at the moment to come up with a test for this :-/ |
|
@ds300 can we get that fix in? That doesn't work for us too - for some reason it's installing the wrong version in the temp directory and generate incorrect patches. |
Collaborator
|
I don't think I get what's happening when it is not working - can someone talk me through how we end up with a bad version? I've never added a specifier after install (and it's not a feature in yarn 3 for example) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Include the package name and version in the
yarnandnpm installcommands.Fixes issue #320