Skip to content
Closed
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 11 additions & 1 deletion .github/workflows/release.yml
Original file line number Diff line number Diff line change
Expand Up @@ -344,7 +344,18 @@ jobs:
pnpm config set exclude-links-from-lockfile true

- name: Update npm
# The Node 22 runner image ships npm 10.9.7, whose @npmcli/arborist
# lazy-loads promise-retry and crashes mid self-upgrade. npm 10.9.8
# (arborist 8.0.5) fixed that by eagerly loading it. We tarball-install
# 10.9.8 as a bootstrap, then use normal `npm install -g` to reach
# npm 11+ which is required for OIDC trusted publishing.
# TODO: drop the tarball step once the runner image ships npm >= 10.9.8.
run: |
NPM_BOOTSTRAP_VERSION="10.9.8"
NPM_DIR="$(dirname "$(dirname "$(which node)")")/lib/node_modules/npm"
sudo rm -rf "${NPM_DIR}"
sudo mkdir -p "${NPM_DIR}"
curl -fsSL "https://registry.npmjs.org/npm/-/npm-${NPM_BOOTSTRAP_VERSION}.tgz" | sudo tar -xz -C "${NPM_DIR}" --strip-components=1
npm install -g npm@^11.6
npm --version

Expand All @@ -363,7 +374,6 @@ jobs:
createGithubReleases: true
env:
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
NPM_TOKEN: "" # See https://github.com/changesets/changesets/issues/1152#issuecomment-3190884868
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removed required NPM_TOKEN for OIDC trusted publishing

High Severity

The NPM_TOKEN: "" environment variable was removed from the "Release new versions" step. This empty-string value is required by changesets/action to signal that OIDC trusted publishing is being used instead of a traditional token. Without it, the action writes "undefined" into .npmrc, causing npm publish to fail. The PR description even references NPM_TOKEN: "" as essential for OIDC trusted publishing, so this removal appears accidental.

Fix in Cursor Fix in Web

Reviewed by Cursor Bugbot for commit 8565b0d. Configure here.

PYPI_TOKEN: ${{ secrets.PYPI_TOKEN }}

- name: Update lock file
Expand Down
Loading