Skip to content

Conversation

@yuwmao
Copy link
Contributor

@yuwmao yuwmao commented Feb 10, 2026

  • Provide the entire membership list in all pg move cb to avoid some potential inconsistency between raft and the user's meta. User can use it for audit or just overwrite(HO example).
  • Use json config instead of raft server memory config. It's because the log might be replayed during restart when the raft server is not initiated.
  • When raft commit a config, it calls save_config before applying to raft memory server config(nuraft reconfigure()).

Previously in PR eBay/HomeObject#386, we discuss the idea to consolidate all the API into "update_membership". But I think the "update_membership" is too specific which restricts the user's behavior that can only update membership even in different phases of PGMove. So I just modify the callbacks' input.

- Provide the entire membership list in all pg move cb to avoid some potential inconsistency between raft and the user's meta.
- Use json config instead of raft server memory config. It's because the log might be replayed during restart when the raft server is not initiated.
- When raft commit a config, it calls save_config before applying to raft memory server config(reconfigure()).
@codecov-commenter
Copy link

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

❌ Patch coverage is 25.00000% with 39 lines in your changes missing coverage. Please review.
✅ Project coverage is 48.27%. Comparing base (1a0cef8) to head (8637a9a).
⚠️ Report is 315 commits behind head on master.

Files with missing lines Patch % Lines
src/lib/replication/repl_dev/raft_repl_dev.cpp 13.63% 28 Missing and 10 partials ⚠️
src/include/homestore/replication/repl_decls.h 85.71% 1 Missing ⚠️
❗ Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #862      +/-   ##
==========================================
- Coverage   56.51%   48.27%   -8.25%     
==========================================
  Files         108      110       +2     
  Lines       10300    12891    +2591     
  Branches     1402     6188    +4786     
==========================================
+ Hits         5821     6223     +402     
+ Misses       3894     2571    -1323     
- Partials      585     4097    +3512     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants