Don't try to generate cultivator token on PR runs#64
Merged
bleggett merged 2 commits intoedera-dev:mainfrom Jan 28, 2026
Merged
Don't try to generate cultivator token on PR runs#64bleggett merged 2 commits intoedera-dev:mainfrom
bleggett merged 2 commits intoedera-dev:mainfrom
Conversation
This fixes spurious publish failures like: edera-dev#56
Contributor
|
Good catch @bleggett, the idea here was that we run the workflow and build the styrolite artifacts then upload them to the workflow run in case anyone wants to download them. Rather than not running on PR, we should just use an |
Contributor
Author
Yep, that's better. I missed the artifact upload would still happen even on PRs. |
found-it
approved these changes
Jan 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Now that the cargo publish/release-plz flow is in place, we don't need to (and cannot) "publish" on PR runs.
This fixes spurious CI publish failures on PRs like:
#56