Skip to content

solana: final schema touchups#1708

Merged
sistemd merged 9 commits intomainfrom
sistemd/solana-add-tx-error-and-version
Feb 9, 2026
Merged

solana: final schema touchups#1708
sistemd merged 9 commits intomainfrom
sistemd/solana-add-tx-error-and-version

Conversation

@sistemd
Copy link
Contributor

@sistemd sistemd commented Feb 7, 2026

  • replace status flag with optional error string
  • add tx version field
  • remove deprecated ui_amount field from the scheme

Copy link

@claude claude bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review Summary

This PR makes schema changes to the Solana transaction table:

  1. Replaces status: bool with err: Option<String> for richer error information
  2. Adds tx_version field to track legacy vs v0 transactions
  3. Removes deprecated ui_amount field from token balances

Critical Issue

Schema mismatch in ui_token_amount_builder(): The builder function still includes the ui_amount: Float64 field (lines 638-653) but the schema definition ui_token_amount_dtype() no longer has it. This will cause runtime errors when building Arrow arrays.

Other Items

  • Unused Float64Builder import after removing ui_amount
  • Minor code simplification opportunities (identity maps)
  • Question about the pattern matching consuming message in extractor.rs (may need &message borrow)

The overall approach of serializing errors as JSON strings is pragmatic - it keeps the schema stable while preserving error details for debugging.

@sistemd sistemd force-pushed the sistemd/solana-add-tx-error-and-version branch from 73c2942 to 7fdeb85 Compare February 7, 2026 17:21
@sistemd sistemd requested review from LNSD and leoyvens February 7, 2026 17:30
@sistemd sistemd merged commit 75e9ee0 into main Feb 9, 2026
7 checks passed
@sistemd sistemd deleted the sistemd/solana-add-tx-error-and-version branch February 9, 2026 12:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants