Merged
Conversation
There was a problem hiding this comment.
Code Review Summary
This PR makes schema changes to the Solana transaction table:
- Replaces
status: boolwitherr: Option<String>for richer error information - Adds
tx_versionfield to track legacy vs v0 transactions - Removes deprecated
ui_amountfield from token balances
Critical Issue
Schema mismatch in ui_token_amount_builder(): The builder function still includes the ui_amount: Float64 field (lines 638-653) but the schema definition ui_token_amount_dtype() no longer has it. This will cause runtime errors when building Arrow arrays.
Other Items
- Unused
Float64Builderimport after removingui_amount - Minor code simplification opportunities (identity maps)
- Question about the pattern matching consuming
messagein extractor.rs (may need&messageborrow)
The overall approach of serializing errors as JSON strings is pragmatic - it keeps the schema stable while preserving error details for debugging.
… the scheme - The `ui_amount` field of token balances has been deprecated and is hence removed. - This also saves us the trouble this field was causing by having a few known mismatches between OF1 and JSON-RPC data.
73c2942 to
7fdeb85
Compare
leoyvens
approved these changes
Feb 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ui_amountfield from the scheme