[ML] Run PyTorch allowlist validation as a dedicated Buildkite step#3010
Open
edsavage wants to merge 1 commit intoelastic:mainfrom
Open
[ML] Run PyTorch allowlist validation as a dedicated Buildkite step#3010edsavage wants to merge 1 commit intoelastic:mainfrom
edsavage wants to merge 1 commit intoelastic:mainfrom
Conversation
The validation was previously inlined in run_tests.sh, but the Linux build/test Docker images don't include Python 3 (it's only used during image builds to compile PyTorch, then dropped in the multi-stage final image). Move the validation to a dedicated pipeline step using a python:3 agent image, triggered only for run_pytorch_tests builds. This runs in parallel with the other post-build steps and soft-fails so it doesn't block the build. Made-with: Cursor
✅ Snyk checks have passed. No issues have been found so far.
💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse. |
Contributor
Author
|
buildkite run_pytorch_tests |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
run_tests.sh, but the Linux Docker build/test images don't include Python 3 (it's used during image builds to compile PyTorch, then dropped in the multi-stage final image). This caused the validation to always skip withOPTIONAL=TRUEor fail without it.python:3agent image, triggered only forrun_pytorch_testsbuilds. Runs in parallel with other post-build steps and soft-fails.Test plan
buildkite run_pytorch_testsand verify the "Validate PyTorch allowlist" step appears and runs in apython:3containerMade with Cursor