Fix -sMODULARIZE + -sLEGACY_VM_SUPPORT#23693
Closed
sbc100 wants to merge 1 commit intoemscripten-core:mainfrom
Closed
Fix -sMODULARIZE + -sLEGACY_VM_SUPPORT#23693sbc100 wants to merge 1 commit intoemscripten-core:mainfrom
sbc100 wants to merge 1 commit intoemscripten-core:mainfrom
Conversation
kripken
approved these changes
Feb 18, 2025
When we run babel in `-sMODULARIZE` mode the input to babel contains `await` calls. This code appears to be top-level code at the point at which we run babel since we have yet to perform the modularization process which wraps the output in a factory function. Fixes: emscripten-core#23687
sbc100
force-pushed
the
modularise_legacy
branch
from
6a79599 to
b4d8041
Compare
Collaborator
Author
|
Closing in favor of #23704 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When we run babel in
-sMODULARIZEmode the input to babel containsawaitcalls. This code appears to be top-level code at the point at which we run babel since we have yet to perform the modularization process which wraps the output in a factory function.Fixes: #23687