Use async/await in libwebaudio.js. NFC#25902
Use async/await in libwebaudio.js. NFC#25902sbc100 wants to merge 1 commit intoemscripten-core:mainfrom
Conversation
e60ac0c to
99129e4
Compare
|
View with "hide whitespace" |
99129e4 to
bad69c1
Compare
|
What does using 'async' provide here? It increases code size, but otherwise seems nonfunctional? |
|
Just modernizing the code, but maybe not worth in this case? If I can't find a way to make it is at least size neutral maybe I will just abandon. |
|
(I do think it makes the code more readable in the modern form, avoid extra indentation etc, but not worth it in this case probably) |
|
My understanding is, |
Correct this would just be an NFC, stylistic change. |
cwoffenden
left a comment
There was a problem hiding this comment.
LGTM. The gzipped JS and wasm size stay the same.
|
I would recommend avoiding this, as it is not necessary, does not provide benefit, and has a code size regression. |
No description provided.