GL_ASSERTIONS: check for MAX_TEMP_BUFFER_SIZE#26098
Merged
sbc100 merged 1 commit intoemscripten-core:mainfrom Jan 17, 2026
Merged
GL_ASSERTIONS: check for MAX_TEMP_BUFFER_SIZE#26098sbc100 merged 1 commit intoemscripten-core:mainfrom
sbc100 merged 1 commit intoemscripten-core:mainfrom
Conversation
sbc100
reviewed
Jan 13, 2026
src/lib/libwebgl.js
Outdated
Collaborator
There was a problem hiding this comment.
Can this just be assert(ringbuffer, `MAX_TEMP_BUFFER_SIZE is not large enough to store a buffer of size ${sizeBytes}`);
Collaborator
|
Seems reasonable to me. WDYT @juj? |
Contributor
Author
|
I also vote for using an assertion. Maybe it’s worth adding the same check for the index buffer; however, I’ve never encountered any issues with it. |
Collaborator
|
Looks good - dev asserts definitely can help improve the error message here. |
juj
approved these changes
Jan 15, 2026
Collaborator
|
@caiiiycuk could you update to use assert here? |
Contributor
Author
|
Done for vertexBuffers, assert not needed for indexBuffers because they are created by demand |
sbc100
approved these changes
Jan 16, 2026
Collaborator
|
I think you need to merge or rebase to fix the CI failures. |
Contributor
Author
|
Rebased |
inolen
pushed a commit
to inolen/emscripten
that referenced
this pull request
Feb 13, 2026
This always happens to me, if you specify not enough MAX_TEMP_BUFFER_SIZE, then you will have non clear error in runtime. With this PR in GL_ASSERTIONS mode, you will have a clean message and information about really needed size of buffer.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This always happens to me, if you specify not enough MAX_TEMP_BUFFER_SIZE, then you will have non clear error in runtime. With this PR in GL_ASSERTIONS mode, you will have a clean message and information about really needed size of buffer.