projectile: make generic scene really generic #1877
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Play this branch at https://play.threadbare.game/branches/endlessm/wjt/projectile-make-generic-scene-really-generic. (This launches the game from the start, not directly at the change(s) in this pull request.) |
wjt
force-pushed
the
wjt/projectile-make-generic-scene-really-generic
branch
from
de8f89b to
767e189
Compare
Previously it had the NO_EDIT sprite frames assigned on the root node, but the ink blob one on the AnimatedSprite2D. At runtime, the former overwrote the latter. This is confusing. Set the same on both. Previously, it had a sound effect assigned on the AudioStreamPlayer2D but not on the root node, and again the root node's null stream would be set on the AudioStreamPlayer2D at runtime. Clear it.
wjt
force-pushed
the
wjt/projectile-make-generic-scene-really-generic
branch
from
767e189 to
bf66d3c
Compare
Member
Author
|
I have several PRs which depend on this one, and we have enough open PRs that publishing to GitHub Pages is failing due to the combined site exceeding 1GB, so I am going to merge this without review. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously it had the NO_EDIT sprite frames assigned on the root node,
but the ink blob one on the AnimatedSprite2D. At runtime, the former
overwrote the latter. This is confusing. Set the same on both.
Previously, it had a sound effect assigned on the AudioStreamPlayer2D
but not on the root node, and again the root node's null stream would be
set on the AudioStreamPlayer2D at runtime. Clear it.