Skip to content

Conversation

@russell-cj
Copy link
Contributor

@russell-cj russell-cj commented Feb 9, 2026

Base shadows have been added to the three ink combat scenes in Quest 001. A new TileMapLayer called Shadows was added to each scene, using the tiles/shadows.tres tileset. Shadows were painted at all contact points between cliffs and the ground.

Resolves #1896

- Added a new `TileMapLayer` called **Shadows**.
- Painted shadows at the base of the cliffs to improve visual depth.

feat #1896
- A new TileMapLayer called Shadows was added to InkCombat combat round 2.
- Shadows were added at the base of the cliffs to improve visual clarity.

feat: #1896
- A new TileMapLayer called Shadows was added to InkCombat combat round 3.
- Corresponding shadows were added at the base of the cliffs to improve visual depth.

feat #1896
@russell-cj russell-cj requested review from manuq and wjt February 9, 2026 19:07
@russell-cj russell-cj self-assigned this Feb 9, 2026
@russell-cj russell-cj requested a review from a team as a code owner February 9, 2026 19:08
@russell-cj russell-cj moved this to In Progress in Threadbare Development Feb 9, 2026
… issues.

- Removed an extra shadow tile that was causing build errors.

Fix: #1896
@github-actions
Copy link

github-actions bot commented Feb 9, 2026

Play this branch at https://play.threadbare.game/branches/endlessm/issue_1896.

(This launches the game from the start, not directly at the change(s) in this pull request.)

@wjt
Copy link
Member

wjt commented Feb 10, 2026

Shadows were painted at all contact points between cliffs and the ground.

Emphasis mine. This is exactly right! Consider these cliffs:

image

You have correctly painted a row of four shadow tiles where I have drawn a purple box - which is where the cliffs meet the ground. You have correctly not painted shadow tiles where I have drawn an orange box. This makes the fake perspective look correct: we are looking down on the scene at an angle, and so we can't see the shadows that are "behind" the cliffs from our point of view.

This took me a while to get my head around for foam - same thing:

image

I wanted to paint foam at the top edge of raised islands like this, until someone explained the perspective point to me.

@wjt
Copy link
Member

wjt commented Feb 10, 2026

One thing I was not sure about at first is the layering of shadows on top of foam:

Screencast.From.2026-02-10.10-31-25.mp4

This is conceptually correct: the cliff must cast a shadow onto the water, and it must be on top of the foam. It's also unavoidable with the way we have the shadow tile set up, because we definitely want the shadow to the right of that cliff where it meets the grass.

I think it looks a little weird but I think it's because I'm not used to it.

@wjt
Copy link
Member

wjt commented Feb 10, 2026

image

For future reference you don't need to explicitly request review - the .github/CODEOWNERS file in the repository has rules that tell GitHub which teams to tag for review, and Manuel and I are in the Games team that is the owner of these files.

@wjt
Copy link
Member

wjt commented Feb 10, 2026

I've edited the description to remove these sections:

Modified scenes

  • ink_combat_round_1.tscn
  • ink_combat_round_2.tscn
  • ink_combat_round_3.tscn

This isn't necessary - Git tells us which files are modified.

🎮 Play 2_ink_combat

Play 2_ink_combat

This is great for testing but the PR message becomes the commit message, and we don't want this link in the permanent commit history because the link will stop working as soon as the PR is merged. Perhaps in future it could be a comment?

@wjt wjt merged commit 663f169 into main Feb 10, 2026
6 checks passed
@wjt wjt deleted the issue_1896 branch February 10, 2026 10:37
@github-project-automation github-project-automation bot moved this from In Progress to Done in Threadbare Development Feb 10, 2026
@russell-cj
Copy link
Contributor Author

Thanks, Will! Everything is very clear now. With these guidelines in mind, executing the remaining sub-tasks will be much more fluid.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

Add cliff shadows: quest_001 - 2_ink_combat

2 participants