Skip to content

Fix unused variables#2001

Merged
bmah888 merged 3 commits intoesnet:masterfrom
WatcherOfTheSkies:fix-unused-variable
Mar 16, 2026
Merged

Fix unused variables#2001
bmah888 merged 3 commits intoesnet:masterfrom
WatcherOfTheSkies:fix-unused-variable

Conversation

@WatcherOfTheSkies
Copy link
Copy Markdown
Contributor

PLEASE NOTE the following text from the iperf3 license. Submitting a
pull request to the iperf3 repository constitutes "[making]
Enhancements available...publicly":

You are under no obligation whatsoever to provide any bug fixes, patches, or
upgrades to the features, functionality or performance of the source code
("Enhancements") to anyone; however, if you choose to make your Enhancements
available either publicly, or directly to Lawrence Berkeley National
Laboratory, without imposing a separate written license agreement for such
Enhancements, then you hereby grant the following license: a non-exclusive,
royalty-free perpetual license to install, use, modify, prepare derivative
works, incorporate into other computer software, distribute, and sublicense
such enhancements or derivative works thereof, in binary and source code form.

The complete iperf3 license is available in the LICENSE file in the
top directory of the iperf3 source tree.

  • Version of iperf3 (or development branch, such as master or
    3.1-STABLE) to which this pull request applies:
    master

  • Issues fixed (if any):
    Fixes warnings when OPENSSL_VERSION_MAJOR <3

  • Brief description of code changes (suitable for use as a commit message):
    Fix unused variables associated with OPENSSL_VERSION_MAJOR

@bmah888
Copy link
Copy Markdown
Contributor

bmah888 commented Mar 16, 2026

Thanks for the PR! This looks good.

These code changes affect builds with OpenSSL < 3. Tested with an old FreeBSD 12 VM, and found that they (correctly) remove two compile warnings about unused variables. No regressions noted with OpenSSL >= 3.

@bmah888 bmah888 merged commit 23fda0d into esnet:master Mar 16, 2026
7 checks passed
@WatcherOfTheSkies WatcherOfTheSkies deleted the fix-unused-variable branch March 17, 2026 08:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants