Skip to content

fix: resolve #254 - preserve headers set via writeHead #273

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
abhii734 wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix: resolve #254 - preserve headers set via writeHead #273

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -101,7 +101,9 @@ function compression (options) {
return false
}

if (!headersSent(res)) {
// Don't overwrite headers if already set via writeHead (e.g., with custom statusText)
// Check res._header to detect if writeHead was already called with headers
if (!headersSent(res) && !res._header) {
this.writeHead(this.statusCode)
}

Expand All @@ -115,7 +117,9 @@ function compression (options) {
return false
}

if (!headersSent(res)) {
// Don't overwrite headers if already set via writeHead (e.g., with custom statusText)
// Check res._header to detect if writeHead was already called with headers
if (!headersSent(res) && !res._header) {
// estimate the length
if (!this.getHeader('Content-Length')) {
length = chunkLength(chunk, encoding)
Expand Down