test(jest): simplify Jest snapshotPathNormalizer.ts #11639
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
While working on #11042 I noticed Jest snapshot path normalizer is a bit uselessly complex, and has multiple synchronous
fs.realpathSynccalls for each path to normalize.It turns out we may not need that "getRealPath" logic
Also, I'm normalizing windows/posix paths as a first-step, because on the linked PR I had snapshot differences like this one on Windows:
Test Plan
CI