Skip to content

Conversation

@slorber
Copy link
Collaborator

@slorber slorber commented Dec 31, 2025

Motivation

While working on #11042 I noticed Jest snapshot path normalizer is a bit uselessly complex, and has multiple synchronous fs.realpathSync calls for each path to normalize.

It turns out we may not need that "getRealPath" logic

Also, I'm normalizing windows/posix paths as a first-step, because on the linked PR I had snapshot differences like this one on Windows:

Test Plan

CI

@slorber slorber added the pr: maintenance This PR does not produce any behavior differences to end users when upgrading. label Dec 31, 2025
@slorber slorber requested a review from Josh-Cena as a code owner December 31, 2025 15:21
@meta-cla meta-cla bot added the CLA Signed Signed Facebook CLA label Dec 31, 2025
@netlify
Copy link

netlify bot commented Dec 31, 2025

[V2]

Name Link
🔨 Latest commit a9ce23c
🔍 Latest deploy log https://app.netlify.com/projects/docusaurus-2/deploys/695568904804290008c4529f
😎 Deploy Preview https://deploy-preview-11639--docusaurus-2.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@github-actions
Copy link

github-actions bot commented Dec 31, 2025

⚡️ Lighthouse report for the deploy preview of this PR

URL Performance Accessibility Best Practices SEO Report
/ 🔴 43 🟢 98 🟢 100 🟢 100 Report
/docs/installation 🟠 55 🟢 97 🟢 100 🟢 100 Report
/docs/category/getting-started 🟠 68 🟢 100 🟢 100 🟠 86 Report
/blog 🟠 68 🟢 96 🟢 100 🟠 86 Report
/blog/preparing-your-site-for-docusaurus-v3 🟠 66 🟢 92 🟢 100 🟢 100 Report
/blog/tags/release 🟠 68 🟢 96 🟢 100 🟠 86 Report
/blog/tags 🟠 70 🟢 100 🟢 100 🟠 86 Report

@slorber slorber merged commit 7bfb41f into main Dec 31, 2025
35 checks passed
@slorber slorber deleted the slorber/simplify-jest-snapshot-serializer branch December 31, 2025 18:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed Signed Facebook CLA pr: maintenance This PR does not produce any behavior differences to end users when upgrading.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants