Move AnimationBackend to its own DisplayLink on iOS #55123
+520
−125
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
meta-cla
bot
added
the
CLA Signed
facebook-github-bot
added
p: Software Mansion
|
@bartlomiejbloniarz has exported this pull request. If you are a Meta employee, you can view the originating Diff in D90327371. |
…tions (facebook#55103) Summary: Pull Request resolved: facebook#55103 This diff decouples AnimationBackend from Animated. Now the backend is intialized in the Scheduler, from where it's passed to UIManager. Animation frontends (such as Animated) can then obtain a reference to the backend, and use it to schedule animation frame updates. # Changelog [General] [Changed] - Moved AnimationBackend initiailzation to `Scheduler` [General] [Added] - `AnimationChoreographer` interface with an implementation for fantom tests Differential Revision: D89663251 Reviewed By: zeyap
…5124) Summary: Pull Request resolved: facebook#55124 On Android AnimationBackend has now its own instance of the Choreographer that it interacts with. # Changelog [General] [Removed] - `UIManagerNativeAnimatedDelegateBackendImpl` [General] [Added] - `AnimationBackendChoreographer` Differential Revision: D90327370
Summary: Pull Request resolved: facebook#55123 On iOS and macOS AnimationBackend has now its own instance of the DisplayLink that it interacts with. # Changelog [General] [Added] - `_animationDisplayLink` to `RCTScheduler` Differential Revision: D90327371
bartlomiejbloniarz
force-pushed
the
export-D90327371
branch
from
3083110 to
ef50e96
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
On iOS and macOS AnimationBackend has now its own instance of the DisplayLink that it interacts with.
Changelog
[General] [Added] -
_animationDisplayLinktoRCTSchedulerDifferential Revision: D90327371