Propagate Hermes V1 opt-in to Fantom#55157
Closed
j-piasecki wants to merge 1 commit intofacebook:mainfrom
Closed
Conversation
meta-cla
bot
added
the
CLA Signed
|
@j-piasecki has exported this pull request. If you are a Meta employee, you can view the originating Diff in D90674696. |
j-piasecki
added a commit
to j-piasecki/react-native
that referenced
this pull request
Jan 14, 2026
Summary: Changelog: [Internal] At the moment, Fantom doesn't propagate the Hermes V1 opt-in to the React Native build, which causes the code that should be gated by compile-time flags to be compiled. Since Hermes V1 differs in some cases, the headers there are missing. This diff adds the opt-in propagation, so the code can be correctly compiled out. Differential Revision: D90674696
j-piasecki
force-pushed
the
export-D90674696
branch
from
752f4ae to
cc689e2
Compare
cortinico
approved these changes
Jan 14, 2026
Contributor
cortinico
left a comment
cortinico
left a comment
There was a problem hiding this comment.
Review automatically exported from Phabricator review in Meta.
Summary: Changelog: [Internal] At the moment, Fantom doesn't propagate the Hermes V1 opt-in to the React Native build, which causes the code that should be gated by compile-time flags to be compiled. Since Hermes V1 differs in some cases, the headers there are missing. This diff adds the opt-in propagation, so the code can be correctly compiled out. Reviewed By: cortinico Differential Revision: D90674696
j-piasecki
force-pushed
the
export-D90674696
branch
from
cc689e2 to
2316ca8
Compare
j-piasecki
added a commit
to j-piasecki/react-native
that referenced
this pull request
Jan 16, 2026
Summary: Changelog: [Internal] At the moment, Fantom doesn't propagate the Hermes V1 opt-in to the React Native build, which causes the code that should be gated by compile-time flags to be compiled. Since Hermes V1 differs in some cases, the headers there are missing. This diff adds the opt-in propagation, so the code can be correctly compiled out. Reviewed By: cortinico Differential Revision: D90674696
j-piasecki
added a commit
to j-piasecki/react-native
that referenced
this pull request
Jan 16, 2026
Summary: Changelog: [Internal] At the moment, Fantom doesn't propagate the Hermes V1 opt-in to the React Native build, which causes the code that should be gated by compile-time flags to be compiled. Since Hermes V1 differs in some cases, the headers there are missing. This diff adds the opt-in propagation, so the code can be correctly compiled out. Reviewed By: cortinico Differential Revision: D90674696
j-piasecki
added a commit
to j-piasecki/react-native
that referenced
this pull request
Jan 16, 2026
Summary: Changelog: [Internal] At the moment, Fantom doesn't propagate the Hermes V1 opt-in to the React Native build, which causes the code that should be gated by compile-time flags to be compiled. Since Hermes V1 differs in some cases, the headers there are missing. This diff adds the opt-in propagation, so the code can be correctly compiled out. Reviewed By: cortinico Differential Revision: D90674696
j-piasecki
added a commit
to j-piasecki/react-native
that referenced
this pull request
Jan 16, 2026
Summary: Changelog: [Internal] At the moment, Fantom doesn't propagate the Hermes V1 opt-in to the React Native build, which causes the code that should be gated by compile-time flags to be compiled. Since Hermes V1 differs in some cases, the headers there are missing. This diff adds the opt-in propagation, so the code can be correctly compiled out. Reviewed By: cortinico Differential Revision: D90674696
Collaborator
|
This pull request was successfully merged by @j-piasecki in 58f9141 When will my fix make it into a release? | How to file a pick request? |
|
This pull request has been merged in 58f9141. |
react-native-bot
pushed a commit
that referenced
this pull request
Jan 19, 2026
Summary: Pull Request resolved: #55157 Changelog: [Internal] At the moment, Fantom doesn't propagate the Hermes V1 opt-in to the React Native build, which causes the code that should be gated by compile-time flags to be compiled. Since Hermes V1 differs in some cases, the headers there are missing. This diff adds the opt-in propagation, so the code can be correctly compiled out. Reviewed By: cortinico Differential Revision: D90674696 fbshipit-source-id: d2adb131af4588e745c023703a893d0ecaaaee01
Collaborator
|
This pull request was successfully merged by @j-piasecki in 2d61709 When will my fix make it into a release? | How to file a pick request? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Changelog: [Internal]
At the moment, Fantom doesn't propagate the Hermes V1 opt-in to the React Native build, which causes the code that should be gated by compile-time flags to be compiled. Since Hermes V1 differs in some cases, the headers there are missing.
This diff adds the opt-in propagation, so the code can be correctly compiled out.
Differential Revision: D90674696