Refactor usage of custom global variables to use value imported from module #55165
+623
−175
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
meta-cla
bot
added
the
CLA Signed
|
@rubennorte has exported this pull request. If you are a Meta employee, you can view the originating Diff in D90588265. |
rubennorte
force-pushed
the
export-D90588265
branch
from
7576144 to
484f35b
Compare
rubennorte
added a commit
to rubennorte/react-native
that referenced
this pull request
Jan 15, 2026
…module (facebook#55165) Summary: Changelog: [internal] This moves all references to global variables within the `react-native` package to consume them from a new module with typed exports instead. This will improve the type safety of globals, by providing accurate types and by easily detecting when a global variable has been removed/changed. Additionally, this is a good way to document all the globals we have, and possibly clean up some of them soon. Reviewed By: yungsters Differential Revision: D90588265
Differential Revision: D90762526
…module (facebook#55165) Summary: Pull Request resolved: facebook#55165 Changelog: [internal] This moves all references to global variables within the `react-native` package to consume them from a new module with typed exports instead. This will improve the type safety of globals, by providing accurate types and by easily detecting when a global variable has been removed/changed. Additionally, this is a good way to document all the globals we have, and possibly clean up some of them soon. Reviewed By: yungsters Differential Revision: D90588265
rubennorte
force-pushed
the
export-D90588265
branch
from
484f35b to
adee187
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Changelog: [internal]
This moves all references to global variables within the
react-nativepackage to consume them from a new module with typed exports instead.This will improve the type safety of globals, by providing accurate types and by easily detecting when a global variable has been removed/changed.
Additionally, this is a good way to document all the globals we have, and possibly clean up some of them soon.
Differential Revision: D90588265