[Android] [Fixed] - Fix fontVariant stylistic sets being ignored in New Architecture #55183
+67
−0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
During an upgrade of ReactNative and switching to new arch, we noticed that Android is ignoring some fontVariants. Specifically
stylistic-{num}. Digging further I noticed that there arestylistic-{num}mappings added tofromRawValue(inpackages/react-native/ReactCommon/react/renderer/attributedstring/conversions.h), but are not included fortoMapBufferChangelog:
[Android] [Fixed] - fontVariants
stylistic-{num}not being propagated correctlyTest Plan:
Before and after in order: