Skip to content

Conversation

@dragoncodes
Copy link

Summary:

During an upgrade of ReactNative and switching to new arch, we noticed that Android is ignoring some fontVariants. Specifically stylistic-{num}. Digging further I noticed that there are stylistic-{num} mappings added to fromRawValue (in packages/react-native/ReactCommon/react/renderer/attributedstring/conversions.h), but are not included for toMapBuffer

Changelog:

[Android] [Fixed] - fontVariants stylistic-{num} not being propagated correctly

Test Plan:

  • Added a new free font (FiraCode) that has stylistic features.
  • Added Text examples for Android showing with and without stylistic features

Before and after in order:

Before After

@meta-cla
Copy link

meta-cla bot commented Jan 15, 2026

Hi @dragoncodes!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at [email protected]. Thanks!

@meta-cla
Copy link

meta-cla bot commented Jan 15, 2026

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!

@meta-cla meta-cla bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jan 15, 2026
@meta-cla
Copy link

meta-cla bot commented Jan 15, 2026

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!

@facebook-github-bot facebook-github-bot added the Shared with Meta Applied via automation to indicate that an Issue or Pull Request has been shared with the team. label Jan 15, 2026
@meta-codesync
Copy link

meta-codesync bot commented Jan 16, 2026

@philIip has imported this pull request. If you are a Meta employee, you can view this in D90830140.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Shared with Meta Applied via automation to indicate that an Issue or Pull Request has been shared with the team.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants