Remove syncAndroidClipToPaddingWithOverflow feature flag#56467
Open
fabriziocucci wants to merge 1 commit intofacebook:mainfrom
Open
Remove syncAndroidClipToPaddingWithOverflow feature flag#56467fabriziocucci wants to merge 1 commit intofacebook:mainfrom
fabriziocucci wants to merge 1 commit intofacebook:mainfrom
Conversation
Summary: Remove the `syncAndroidClipToPaddingWithOverflow` feature flag and all associated logic. This flag synced Android `clipToPadding` with the CSS `overflow` property, but `clipToPadding` has no effect when padding is 0 (the default for most RN views), making the entire mechanism insufficient. We will replace this with `setClipBounds()` in a follow-up diff (T253147322). - Remove clipToPadding logic from `ReactViewGroup.initView()` and `overflow` setter - Remove `getClipToPadding()` overrides from ReactScrollView, ReactHorizontalScrollView - Regenerate ReactNestedScrollView from updated ReactScrollView source - Remove hardcoded override from ReactNativeFeatureFlagsOverrides_PanelApp - Remove flag definition from ReactNativeFeatureFlags.config.js and regenerate all feature flag infrastructure files Reviewed By: zeyap Differential Revision: D101153619
meta-cla
bot
added
the
CLA Signed
|
@fabriziocucci has exported this pull request. If you are a Meta employee, you can view the originating Diff in D101153619. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Remove the
syncAndroidClipToPaddingWithOverflowfeature flag and all associated logic.This flag synced Android
clipToPaddingwith the CSSoverflowproperty, butclipToPaddinghas no effect when padding is 0 (the default for most RN views),making the entire mechanism insufficient. We will replace this with
setClipBounds()in a follow-up diff (T253147322).
ReactViewGroup.initView()andoverflowsettergetClipToPadding()overrides from ReactScrollView, ReactHorizontalScrollViewfeature flag infrastructure files
Reviewed By: zeyap
Differential Revision: D101153619