[DevTools] Fix ReDoS vulnerability in Firefox stack trace parser#35509
Open
yujiteshima wants to merge 1 commit intofacebook:mainfrom
Open
[DevTools] Fix ReDoS vulnerability in Firefox stack trace parser#35509yujiteshima wants to merge 1 commit intofacebook:mainfrom
yujiteshima wants to merge 1 commit intofacebook:mainfrom
Conversation
|
Hi, @yujiteshima @gnoff Whether you need to actively request a review will determine whether the subsequent process will proceed. Best regards |
aarushdubey
added a commit
to aarushdubey/react
that referenced
this pull request
Jan 23, 2026
- Replace vulnerable regex pattern with safe alternative - Use negated character class [^@] instead of nested quantifiers - Prevents catastrophic backtracking on malicious input - Maintains identical matching behavior for valid stack traces Reference: PR facebook#35509 Fixes facebook#35490
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes a ReDoS (Regular Expression Denial of Service) vulnerability in the Firefox stack trace parser.
Fixes #35490
The original regex pattern
(?:.*".+")?[^@]*infirefoxFrameRegExpcontained nested quantifiers that could cause catastrophic backtracking when processing malicious inputs. With a crafted input containing 2000 repeated patterns, the regex took over 2.5 seconds to process, causing the DevTools to become unresponsive.The fix: Changed
.*".+"to"[^"]+"using a negated character class. This achieves O(n) linear time complexity while preserving identical matching behavior for all valid Firefox stack frames.How did you test this change?
Added a regression test to prevent future ReDoS vulnerabilities in this regex.
Ran the standard checks: