Optimize gesture by allowing the original work in progress tree to be a suspended commit #35510
+401
−158
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instead of keeping track of which gestures to stop during the next commit, we instead track on the pending gesture whether that gesture should commit that lane next time we get there in the React commit sequence.
When completing a root we can apply the gesture which starts the animation but it's not committed. We mark the lane as suspended at that point.
This will rerender the gesture lane and then commit it which stops the gesture. After that any Transitions can be applied on top.
…commits This part doesn't animate until we release.
github-actions
bot
added
the
React Core Team
sebmarkbage
commented
Jan 14, 2026
| startTransition(action); | ||
| } | ||
| // We cancel the gesture before invoking side-effects to allow the gesture lane to fully commit | ||
| // before scheduling new updates. |
Collaborator
Author
There was a problem hiding this comment.
This might actually be wrong because it wouldn't know what to entangle with until later. Nevermind this works because we entangle all transitions in the same event.
acdlite
approved these changes
Jan 14, 2026
This is equivalent to the "Commit" phase in the regular phases but it's creating a "ghost" DOM tree that's a partial clone of the old one that's immediately deleted.
This ensures that we log the end state of the Animating track which otherwise is ignored inside a commit phase.
Collaborator
Author
|
I also pushed some commits related to performance track logging of these new types of phases and gaps. |
sebmarkbage
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stacked on #35487.
This is slightly different because the first suspended commit is on blockers that prevent us from committing which still needs to be resolved first.
If a gesture lane has to be rerendered while the gesture is happening then it reenters this state with a new tree. (Currently this doesn't happen for a ping I think which is not really how it usually works but better in this case.)