-
Notifications
You must be signed in to change notification settings - Fork 50.5k
[Flight] Allow overriding request.timeOrigin via options.startTime
#35598
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Comparing: 5dad2b4...ddea9a9 Critical size changesIncludes critical production bundles, as well as any change greater than 2%:
Significant size changesIncludes any change greater than 0.2%: Expand to show
|
4bdc1b0 to
7367c43
Compare
ed52431 to
fd12cde
Compare
bfa9c36 to
69f8ea8
Compare
0375bee to
19ea0a5
Compare
request.timeOriginrequest.timeOrigin via options.startTime
19ea0a5 to
07e700c
Compare
lubieowoce
commented
Feb 2, 2026
| ' in ' + | ||
| name + | ||
| (/\d/.test(m) | ||
| (/:\d+:\d+/.test(m) |
Contributor
Author
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
drive-by fix. detecting only numbers would make Component1 look like a source location.
unstubbable
reviewed
Feb 3, 2026
packages/react-server-dom-esm/src/server/ReactFlightDOMServerNode.js
Outdated
Show resolved
Hide resolved
8b7fa18 to
2ce72e7
Compare
unstubbable
approved these changes
Feb 3, 2026
2ce72e7 to
ddea9a9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, IO that finished before the request started is not considered IO:
react/packages/react-server/src/ReactFlightServer.js
Lines 5338 to 5343 in 6a0ab4d
This leads to loss of debug info when a flight stream is deserialized and serialized again.
We can solve this by allowing "when the the request started" to be set to a point in the past, when the original stream started by doing