Skip to content

Conversation

@lubieowoce
Copy link
Contributor

@lubieowoce lubieowoce commented Jan 22, 2026

Currently, IO that finished before the request started is not considered IO:

const ioInfo = info.awaited;
if (ioInfo.end <= request.timeOrigin) {
// This was already resolved when we started this render. It must have been some
// externally cached data. We exclude that information but we keep components and
// awaits that happened inside this render but might have been deduped within the
// render.

This leads to loss of debug info when a flight stream is deserialized and serialized again.
We can solve this by allowing "when the the request started" to be set to a point in the past, when the original stream started by doing

const startTime = performance.now() + performance.timeOrigin
// ... stuff happens and time passes...
ReactServer.renderToReadableStream(..., { startTime })

@meta-cla meta-cla bot added the CLA Signed label Jan 22, 2026
@react-sizebot
Copy link

react-sizebot commented Jan 22, 2026

Comparing: 5dad2b4...ddea9a9

Critical size changes

Includes critical production bundles, as well as any change greater than 2%:

Name +/- Base Current +/- gzip Base gzip Current gzip
oss-stable/react-dom/cjs/react-dom.production.js = 6.84 kB 6.84 kB = 1.88 kB 1.88 kB
oss-stable/react-dom/cjs/react-dom-client.production.js = 609.91 kB 609.91 kB = 107.85 kB 107.85 kB
oss-experimental/react-dom/cjs/react-dom.production.js = 6.84 kB 6.84 kB = 1.88 kB 1.88 kB
oss-experimental/react-dom/cjs/react-dom-client.production.js = 675.84 kB 675.84 kB = 118.81 kB 118.81 kB
facebook-www/ReactDOM-prod.classic.js = 695.47 kB 695.47 kB = 122.24 kB 122.24 kB
facebook-www/ReactDOM-prod.modern.js = 685.85 kB 685.85 kB = 120.63 kB 120.63 kB

Significant size changes

Includes any change greater than 0.2%:

Expand to show
Name +/- Base Current +/- gzip Base gzip Current gzip
oss-experimental/react-noop-renderer/cjs/react-noop-renderer-flight-server.production.js +1.80% 2.44 kB 2.49 kB +0.98% 0.81 kB 0.82 kB
oss-stable-semver/react-noop-renderer/cjs/react-noop-renderer-flight-server.production.js +1.80% 2.44 kB 2.49 kB +0.98% 0.81 kB 0.82 kB
oss-stable/react-noop-renderer/cjs/react-noop-renderer-flight-server.production.js +1.80% 2.44 kB 2.49 kB +0.98% 0.81 kB 0.82 kB
oss-experimental/react-noop-renderer/cjs/react-noop-renderer-flight-server.development.js +1.55% 3.10 kB 3.14 kB +0.74% 0.95 kB 0.95 kB
oss-stable-semver/react-noop-renderer/cjs/react-noop-renderer-flight-server.development.js +1.55% 3.10 kB 3.14 kB +0.74% 0.95 kB 0.95 kB
oss-stable/react-noop-renderer/cjs/react-noop-renderer-flight-server.development.js +1.55% 3.10 kB 3.14 kB +0.74% 0.95 kB 0.95 kB

Generated by 🚫 dangerJS against ddea9a9

@lubieowoce lubieowoce force-pushed the preserve-old-io-info branch 4 times, most recently from 4bdc1b0 to 7367c43 Compare January 22, 2026 15:43
@lubieowoce lubieowoce force-pushed the preserve-old-io-info branch from ed52431 to fd12cde Compare January 29, 2026 18:08
@lubieowoce lubieowoce marked this pull request as ready for review January 29, 2026 18:16
@lubieowoce lubieowoce force-pushed the preserve-old-io-info branch 8 times, most recently from bfa9c36 to 69f8ea8 Compare January 30, 2026 00:59
@eps1lon eps1lon requested review from gnoff and unstubbable January 30, 2026 10:58
@lubieowoce lubieowoce force-pushed the preserve-old-io-info branch 3 times, most recently from 0375bee to 19ea0a5 Compare February 2, 2026 17:15
@lubieowoce lubieowoce changed the title [Flight] Allow overriding request.timeOrigin [Flight] Allow overriding request.timeOrigin via options.startTime Feb 2, 2026
@lubieowoce lubieowoce force-pushed the preserve-old-io-info branch from 19ea0a5 to 07e700c Compare February 2, 2026 17:23
' in ' +
name +
(/\d/.test(m)
(/:\d+:\d+/.test(m)
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

drive-by fix. detecting only numbers would make Component1 look like a source location.

@lubieowoce lubieowoce force-pushed the preserve-old-io-info branch from 8b7fa18 to 2ce72e7 Compare February 3, 2026 13:31
@lubieowoce lubieowoce force-pushed the preserve-old-io-info branch from 2ce72e7 to ddea9a9 Compare February 3, 2026 14:21
@unstubbable unstubbable merged commit b1533b0 into facebook:main Feb 3, 2026
234 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants