Fix compatibility with ImGui 1.91.5+ and 1.92.6+#2
Merged
Conversation
* based on upstream PR thedmd#331. * replace removed ImRect::Floor() with FloorRect() helper and deprecated GetKeyIndex() with IsKeyPressedCompat() — both with backward-compatible version guards. * update vendored ImGui to v1.92.6-docking and fix examples - update external/imgui from v1.84 (thedmd fork) to v1.92.6-docking (stock ocornut/imgui) for smoke-testing the compatibility patch. - replace ancient imgui_impl_glfw/opengl3 backends with 1.92.6 versions. - fix ImTextureID type change (void* -> ImU64) in renderer and examples. - fix font atlas initialization for new texture management API. - fix obsoleted PushButtonRepeat -> PushItemFlag in widgets-example. - fix GetKeyIndex removal in blueprints-example. *Note: blueprints-example cannot build with stock ImGui — it requires ImGui::Spring/BeginHorizontal/BeginVertical from the thedmd/imgui fork.* Signed-off-by: Ralph J. Steinhagen <r.steinhagen@gsi.de>
wirew0rm
approved these changes
Mar 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note: blueprints-example cannot build with stock ImGui — it requires ImGui::Spring/BeginHorizontal/BeginVertical from the thedmd/imgui fork.
Smoke test (repo has no unit-tests):