Skip to content

chore: push, don't overwrite history so browser works#1433

Merged
jescalada merged 4 commits intofinos:mainfrom
qube-rt:fix-dashboard-navigation
Mar 3, 2026
Merged

chore: push, don't overwrite history so browser works#1433
jescalada merged 4 commits intofinos:mainfrom
qube-rt:fix-dashboard-navigation

Conversation

@andypols
Copy link
Contributor

@andypols andypols commented Mar 2, 2026

Summary

This PR fixes a bug where navigation history was being lost, causing the browser back button to behave unexpectedly. For example, navigating from repositories (/dashboard/repo) to the dashboard (/dashboard/push), then into a specific push, and pressing Back would return you to /dashboard/repo instead of /dashboard/push.

Fix

This fix removes { replace: true } so navigation always pushes a new history entry, and the browser back button correctly returns to the previous page

@andypols andypols requested a review from a team as a code owner March 2, 2026 13:36
@netlify
Copy link

netlify bot commented Mar 2, 2026

Deploy Preview for endearing-brigadeiros-63f9d0 canceled.

Name Link
🔨 Latest commit 0a25231
🔍 Latest deploy log https://app.netlify.com/projects/endearing-brigadeiros-63f9d0/deploys/69a6b95eb60d1c000831ba22

@codecov
Copy link

codecov bot commented Mar 2, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 81.77%. Comparing base (3872b14) to head (0a25231).
⚠️ Report is 5 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1433   +/-   ##
=======================================
  Coverage   81.77%   81.77%           
=======================================
  Files          67       67           
  Lines        4769     4769           
  Branches      827      827           
=======================================
  Hits         3900     3900           
  Misses        853      853           
  Partials       16       16           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Contributor

@jescalada jescalada left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, replace: true is only really good for preventing users from going back to login pages or forms which isn't the case here.

@jescalada jescalada enabled auto-merge March 3, 2026 07:13
@jescalada jescalada merged commit 0448190 into finos:main Mar 3, 2026
25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants