chore: push, don't overwrite history so browser works#1433
Merged
jescalada merged 4 commits intofinos:mainfrom Mar 3, 2026
Merged
chore: push, don't overwrite history so browser works#1433jescalada merged 4 commits intofinos:mainfrom
jescalada merged 4 commits intofinos:mainfrom
Conversation
✅ Deploy Preview for endearing-brigadeiros-63f9d0 canceled.
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1433 +/- ##
=======================================
Coverage 81.77% 81.77%
=======================================
Files 67 67
Lines 4769 4769
Branches 827 827
=======================================
Hits 3900 3900
Misses 853 853
Partials 16 16 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
jescalada
approved these changes
Mar 3, 2026
Contributor
jescalada
left a comment
There was a problem hiding this comment.
LGTM, replace: true is only really good for preventing users from going back to login pages or forms which isn't the case here.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes a bug where navigation history was being lost, causing the browser back button to behave unexpectedly. For example, navigating from repositories (
/dashboard/repo) to the dashboard (/dashboard/push), then into a specific push, and pressing Back would return you to/dashboard/repoinstead of/dashboard/push.Fix
This fix removes
{ replace: true }so navigation always pushes a new history entry, and the browser back button correctly returns to the previous page