Skip to content

Consolidate the ABIU prompts in the CLI so it matches the UI behavior#10352

Merged
falahat merged 4 commits intonextfrom
abiu_selection
Apr 16, 2026
Merged

Consolidate the ABIU prompts in the CLI so it matches the UI behavior#10352
falahat merged 4 commits intonextfrom
abiu_selection

Conversation

@falahat
Copy link
Copy Markdown
Contributor

@falahat falahat commented Apr 15, 2026

Description

Today, ABIU and Runtime are two separate selections in the CLI.
This PR merges them into one selection. If you select an ABIU-enabled runtime, you automatically enable ABIU. If you want to disable ABIU, you can use the "nodejs" runtime

Scenarios Tested

  • Created an ABIU backend runtime=nodejs22, it was marked as ABIU=enabled as expected
  • Created a backend with runtime=nodejs noninteractively, it was marked as non-ABIU as expected
  • Went through the interactive flow for backend creation and the prompt looked as expected. It correctly showed that nodejs would disable ABIU.

@falahat falahat requested a review from Yuangwang April 15, 2026 16:39
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request simplifies the App Hosting backend creation process by removing the explicit toggle for Automatic Base Image Updates (ABIU). ABIU support is now integrated into the runtime selection, where the promptRuntime utility displays whether a specific runtime supports the feature. As a result, the --automatic-base-image-updates and --no-automatic-base-image-updates flags, along with their associated prompts and logic, have been removed from the CLI and internal setup functions. I have no feedback to provide.

@falahat falahat marked this pull request as ready for review April 15, 2026 16:55
@falahat falahat changed the base branch from main to next April 15, 2026 20:39
@falahat falahat changed the base branch from next to main April 15, 2026 20:40
@falahat falahat changed the base branch from main to next April 16, 2026 13:41
@falahat falahat merged commit 63a529e into next Apr 16, 2026
5 checks passed
@falahat falahat deleted the abiu_selection branch April 16, 2026 13:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants