Conversation
Summary of ChangesHello @huangjeff5, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request introduces a fundamental refactoring of the plugin system, transitioning to an asynchronous, lazy-loading architecture. This change streamlines how external functionalities are integrated and managed within the framework, improving efficiency and flexibility by resolving actions on demand rather than during initial setup. The update impacts the core registry, reflection mechanisms, and all existing plugins, ensuring a consistent and modern approach to extensibility. Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request is a major refactoring of the plugin system to a new asynchronous "V2" API. The changes are extensive, touching core registry logic, all existing plugins, and tests. The new plugin interface is cleaner and async-first. Most of the changes correctly adapt the codebase to this new model, including significant improvements to streaming logic in the reflection server and bug fixes in request handling. However, the refactoring appears to be incomplete for the VertexAIVectorSearch plugin, as its new init method is empty, effectively disabling its functionality. This is a critical issue that needs to be addressed.
py/plugins/vertex-ai/src/genkit/plugins/vertex_ai/vector_search/vector_search.py
Outdated
Show resolved
Hide resolved
py/plugins/compat-oai/src/genkit/plugins/compat_oai/openai_plugin.py
Outdated
Show resolved
Hide resolved
py/plugins/compat-oai/src/genkit/plugins/compat_oai/openai_plugin.py
Outdated
Show resolved
Hide resolved
py/plugins/dev-local-vectorstore/src/genkit/plugins/dev_local_vectorstore/plugin_api.py
Outdated
Show resolved
Hide resolved
py/plugins/google-genai/src/genkit/plugins/google_genai/google.py
Outdated
Show resolved
Hide resolved
py/plugins/google-genai/src/genkit/plugins/google_genai/models/gemini.py
Outdated
Show resolved
Hide resolved
|
@huangjeff5 The GenkitEvaluators plugin (in py/plugins/evaluators) needs to be refactored with this new refactor. Since it requires access to the ai (Genkit) instance to run flows, it might need a different initialization pattern or the Plugin.init method needs to be able to access the registry/instance.Probably we can update it in another pr. |
zarinn3pal
left a comment
There was a problem hiding this comment.
@huangjeff5 The samples run fine. Some devui components are not properly displayed. Can be fixed in next PR.

No description provided.