Experiment with a command-line tool for querying profile contents#5663
Draft
mstange wants to merge 5 commits intofirefox-devtools:mainfrom
Draft
Experiment with a command-line tool for querying profile contents#5663mstange wants to merge 5 commits intofirefox-devtools:mainfrom
mstange wants to merge 5 commits intofirefox-devtools:mainfrom
Conversation
This logic can be useful independently of redux actions, for CLI scripts which want to support profiler URLs.
A `yarn test:cli` script was added to run only the cli tests, but it looks like the main tests are also running them since they match the testMatch glob.
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #5663 +/- ##
==========================================
- Coverage 85.56% 82.85% -2.72%
==========================================
Files 319 329 +10
Lines 31420 33541 +2121
Branches 8661 9211 +550
==========================================
+ Hits 26885 27790 +905
- Misses 4104 5324 +1220
+ Partials 431 427 -4 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sometimes I've wanted to inspect profiles from the command line, without loading them in the web UI.
Here's an experiment I've been working on, which creates a
pqtool ("profile query"). To test, clone this branch and runyarn build-profile-query-cli- this creates a./dist/pq.jsartifact. Then somehow make it accessible via your path, for example by putting a shell script with the contentsnode ~/code/profiler/dist/pq.js $@into abindirectory in your path.pq load 'https://share.firefox.dev/hash'orpq load profile.json.gzstart a session.Only tested on macOS so far. It uses unix domain sockets so it probably doesn't work on Windows atm.