Skip to content

Update return code to 400 when invalid activity ids are provided#4182

Merged
filiphr merged 1 commit intoflowable:mainfrom
gdharley:bugfix/15664-ChangeActivityState-return-code
Mar 11, 2026
Merged

Update return code to 400 when invalid activity ids are provided#4182
filiphr merged 1 commit intoflowable:mainfrom
gdharley:bugfix/15664-ChangeActivityState-return-code

Conversation

@gdharley
Copy link
Contributor

@gdharley gdharley commented Mar 10, 2026

Check List:

  • Unit tests: YES / NO / NA
  • Documentation: YES / NO / NA

@gdharley
Copy link
Contributor Author

gdharley commented Mar 10, 2026

Broke some existing unit tests

@gdharley gdharley closed this Mar 10, 2026
@gdharley gdharley reopened this Mar 10, 2026
@gdharley gdharley force-pushed the bugfix/15664-ChangeActivityState-return-code branch from a9734f7 to 51dae64 Compare March 10, 2026 20:56
filiphr
filiphr requested changes Mar 10, 2026
View reviewed changes
Copy link
Contributor

@filiphr filiphr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @gdharley. This is a great improvement. I've added 2 small comments. I think we don't really need to change anything in the Rest Controllers if we throw the right exceptions in the implementation

@gdharley gdharley force-pushed the bugfix/15664-ChangeActivityState-return-code branch from 51dae64 to 21f7623 Compare March 11, 2026 14:47
@filiphr filiphr merged commit a74447c into flowable:main Mar 11, 2026
3 checks passed
@filiphr
Copy link
Contributor

filiphr commented Mar 11, 2026

Thanks @gdharley

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@filiphr filiphr filiphr requested changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@gdharley @filiphr