Conversation
Signed-off-by: BOSLET, CORY <cb645j+ATT@att.com>
📝 WalkthroughWalkthroughA new configuration option Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~5 minutes Poem
🚥 Pre-merge checks | ✅ 2 | ❌ 1❌ Failed checks (1 inconclusive)
✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 3
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@pipeline/outputs/opentelemetry.md`:
- Line 41: Update the param table row for logs_resource_attributes_message_key
so its description clearly states that this key names a message-field whose
value will be promoted into the OpenTelemetry Resource attributes (distinct from
logs_resource_metadata_key which maps metadata fields); replace the vague text
with an explicit phrase like “Specify the message field key whose value will be
promoted into the Resource attributes.”
- Line 139: The fluent-bit.conf example includes a new option that is missing
from the fluent-bit.yaml example; update the YAML example in
pipeline/outputs/opentelemetry.md (the fluent-bit.yaml code block around the
current examples) to include the equivalent key/value entry so both examples
demonstrate the same feature set—locate the fluent-bit.conf block to see the
exact option name and value, then add the matching YAML mapping/key under the
fluent-bit.yaml section with the same semantic setting and a brief inline
comment mirroring the conf example.
- Around line 189-190: Remove the invalid Fluent Bit OpenTelemetry output option
`logs_resource_attributes_message_key` and instead demonstrate configuring
resource attributes via a processors pipeline using the `opentelemetry_envelope`
processor with `content_modifier`; specifically, delete the two lines containing
`logs_resource_attributes_message_key application_id` and
`logs_resource_attributes_message_key service_name` and replace (or document)
using an `opentelemetry_envelope` processor block with `content_modifier` rules
to add/rename resource attributes for logs as per the OpenTelemetry processor
usage.
| | `logs_metadata_key` | Set the key to look up in the metadata. | `otlp` | | ||
| | `logs_resource_metadata_key` | Specify a `Resource` key. | `Resource` | | ||
| | `logs_resource_metadata_key` | Specify a `Resource` key. | `Resource` | ||
| | `logs_resource_attributes_message_key` | Specify a `Resource` key. | _none_ | |
There was a problem hiding this comment.
Clarify the new key’s purpose in the parameter table.
At Line 41, the description currently matches logs_resource_metadata_key semantics and is too vague. Please make it explicit that this is a message-field key promoted into Resource attributes.
Suggested doc wording
-| `logs_resource_attributes_message_key` | Specify a `Resource` key. | _none_ |
+| `logs_resource_attributes_message_key` | Specify a message key whose value is added as a `Resource` attribute. | _none_ |📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| | `logs_resource_attributes_message_key` | Specify a `Resource` key. | _none_ | | |
| | `logs_resource_attributes_message_key` | Specify a message key whose value is added as a `Resource` attribute. | _none_ | |
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.
In `@pipeline/outputs/opentelemetry.md` at line 41, Update the param table row for
logs_resource_attributes_message_key so its description clearly states that this
key names a message-field whose value will be promoted into the OpenTelemetry
Resource attributes (distinct from logs_resource_metadata_key which maps
metadata fields); replace the vague text with an explicit phrase like “Specify
the message field key whose value will be promoted into the Resource
attributes.”
There was a problem hiding this comment.
@cb645j add a bit more clarity for each one in the description please.
There was a problem hiding this comment.
Seems like the humans are having a chat. I'll hop back into my burrow for now. If you need me again, just tag @coderabbitai in a new comment, and I'll come hopping out!
| logs_trace_id_message_key: trace_id | ||
| logs_severity_text_message_key: loglevel | ||
| logs_severity_number_message_key: lognum | ||
|
|
There was a problem hiding this comment.
Keep YAML and classic config examples aligned.
The new option is shown in the fluent-bit.conf example but not in fluent-bit.yaml near Line 139. Please add the YAML equivalent so both examples demonstrate the same feature set.
Suggested YAML addition
logs_severity_text_message_key: loglevel
logs_severity_number_message_key: lognum
+ logs_resource_attributes_message_key: application_id🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.
In `@pipeline/outputs/opentelemetry.md` at line 139, The fluent-bit.conf example
includes a new option that is missing from the fluent-bit.yaml example; update
the YAML example in pipeline/outputs/opentelemetry.md (the fluent-bit.yaml code
block around the current examples) to include the equivalent key/value entry so
both examples demonstrate the same feature set—locate the fluent-bit.conf block
to see the exact option name and value, then add the matching YAML mapping/key
under the fluent-bit.yaml section with the same semantic setting and a brief
inline comment mirroring the conf example.
There was a problem hiding this comment.
Seems like the humans are having a chat. I'll hop back into my burrow for now. If you need me again, just tag @coderabbitai in a new comment, and I'll come hopping out!
|
@cb645j a few ai review issues to be solved please, see above comment. |
Summary by CodeRabbit
New Features
Documentation