Skip to content

Address benchmark and integration test flakiness #9690

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
elliette merged 2 commits into from
Mar 10, 2026
Merged

Address benchmark and integration test flakiness #9690

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0fbfd14
Fix first benchmark failure
elliette Mar 7, 2026
3aa3098
Try to fix other failure
elliette Mar 10, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
33 changes: 27 additions & 6 deletions packages/devtools_test/lib/src/helpers/actions.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -110,10 +110,26 @@ Future<void> switchToScreen(
);
_maybeExpect(tabFinder, findsOneWidget, shouldExpect: runWithExpectations);

await controller.tap(tabFinder, warnIfMissed: warnIfTapMissed);
// We use pump here instead of pumpAndSettle because pumpAndSettle will
// never complete if there is an animation (e.g. a progress indicator).
await controller.pump(safePumpDuration);
await retryAsync<bool>(
() async {
try {
await controller.tap(tabFinder, warnIfMissed: warnIfTapMissed);
// We use pump here instead of pumpAndSettle because pumpAndSettle will
// never complete if there is an animation (e.g. a progress indicator).
await controller.pump(safePumpDuration);
return true;
} catch (e) {
logStatus('Attempt to switch to $screenId failed with error: $e');
return false;
}
},
condition: (success) => success,
onRetry: () async {
logStatus('Retrying switch to $screenId...');
// Try pumping again to give UI time to settle.
await controller.pump(safePumpDuration);
},
);
}

/// Finds the tab with [icon] either in the top-level DevTools tab bar or in the
Expand Down Expand Up @@ -174,7 +190,10 @@ Future<void> loadSampleData(
/// 2) access the [Scrollbar] widget's [ScrollController].
/// 3) scroll the scrollable attached to the [ScrollController] to the end of
/// the [ScrollController]'s scroll extent.
Future<void> scrollToEnd<T>(WidgetController controller) async {
Future<void> scrollToEnd<T>(
WidgetController controller, {
bool waitForSettle = true,
}) async {
final scrollbarFinder = find.descendant(
of: find.byType(T),
matching: find.byType(Scrollbar),
Expand All @@ -185,5 +204,7 @@ Future<void> scrollToEnd<T>(WidgetController controller) async {
duration: const Duration(milliseconds: 500),
curve: Curves.easeInOutCubic,
);
await controller.pump(shortPumpDuration);
await (waitForSettle
? controller.pumpAndSettle(shortPumpDuration)
: controller.pump(shortPumpDuration));
}
Loading