[camera_avfoundation] Wrappers swift migration - part 6#10752
Merged
auto-submit[bot] merged 5 commits intoflutter:mainfrom Jan 22, 2026
Merged
Conversation
RobertOdrowaz
commented
Jan 8, 2026
packages/camera/camera_avfoundation/example/ios/RunnerTests/Mocks/MockAssetWriter.swift
Show resolved
Hide resolved
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request continues the migration of the camera_avfoundation plugin from Objective-C to Swift, focusing on several wrapper and utility classes like FLTSavePhotoDelegate, FLTWritableData, FLTImageStreamHandler, CameraProperties, and QueueUtils. The migration is well-executed, adhering to Swift conventions by removing the 'FLT' prefixes and adopting modern Swift patterns.
My review includes a few suggestions:
- A potential bug in
SavePhotoDelegatewhere anilphoto data case is not handled, leading to a false success report. - A correction for misleading documentation in
SavePhotoDelegate.swift. - A recommendation to use
preconditionFailureinstead ofassertionFailureinCameraProperties.swiftfor a known invalid input to ensure robustness in release builds.
...era_avfoundation/ios/camera_avfoundation/Sources/camera_avfoundation/SavePhotoDelegate.swift
Show resolved
Hide resolved
...mera_avfoundation/ios/camera_avfoundation/Sources/camera_avfoundation/CameraProperties.swift
Show resolved
Hide resolved
...era_avfoundation/ios/camera_avfoundation/Sources/camera_avfoundation/SavePhotoDelegate.swift
Outdated
Show resolved
Hide resolved
RobertOdrowaz
commented
Jan 8, 2026
packages/camera/camera_avfoundation/example/ios/RunnerTests/CameraPropertiesTests.swift
Show resolved
Hide resolved
packages/camera/camera_avfoundation/example/ios/RunnerTests/Mocks/MockWritableData.swift
Outdated
Show resolved
Hide resolved
packages/camera/camera_avfoundation/example/ios/RunnerTests/StreamingTests.swift
Show resolved
Hide resolved
...era_avfoundation/ios/camera_avfoundation/Sources/camera_avfoundation/SavePhotoDelegate.swift
Show resolved
Hide resolved
...vfoundation/ios/camera_avfoundation/Sources/camera_avfoundation/ThreadSafeEventChannel.swift
Show resolved
Hide resolved
RobertOdrowaz
force-pushed
the
feature/camera-wrappers-swift-migration-part6
branch
from
34ecb9b to
8d3b1ab
Compare
Contributor
Author
|
@hellohuanlin You can take a look again (I've resolved the nit and responded to the rest of the comments) |
hellohuanlin
approved these changes
Jan 21, 2026
...vfoundation/ios/camera_avfoundation/Sources/camera_avfoundation/ThreadSafeEventChannel.swift
Show resolved
Hide resolved
RobertOdrowaz
added
the
autosubmit
linchen00
pushed a commit
to linchen00/packages
that referenced
this pull request
Jan 23, 2026
Migrates camera wrappers as part of flutter/flutter#119109 This (last wrappers related 🎉) PR migrates wrappers to Swift: * `FLTSavePhotoDelegate` * `FLTWritableData` * `FLTImageStreamHandler` * `CameraProperties` * `QueueUtils` In line with Swift conventions, the `FLT` prefixes are removed. ## Pre-Review Checklist **Note**: The Flutter team is currently trialing the use of [Gemini Code Assist for GitHub](https://developers.google.com/gemini-code-assist/docs/review-github-code). Comments from the `gemini-code-assist` bot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed. [^1]: Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling. (cherry picked from commit 2dc24c5)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jan 23, 2026
github-merge-queue bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Jan 23, 2026
flutter/packages@9010299...5af5f50 2026-01-23 6655696+guidezpl@users.noreply.github.com Update Google Fonts to v8.0.0 with new and removed fonts (flutter/packages#10785) 2026-01-22 stuartmorgan@google.com [pigeon] Modernize Obj-C generation headers (flutter/packages#10857) 2026-01-22 47866232+chunhtai@users.noreply.github.com Fixes sync_release_pr workflow yaml formatting (flutter/packages#10855) 2026-01-22 robert.odrowaz@leancode.pl [camera_avfoundation] Wrappers swift migration - part 6 (flutter/packages#10752) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC flutter-ecosystem@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Migrates camera wrappers as part of flutter/flutter#119109
This (last wrappers related 🎉) PR migrates wrappers to Swift:
FLTSavePhotoDelegateFLTWritableDataFLTImageStreamHandlerCameraPropertiesQueueUtilsIn line with Swift conventions, the
FLTprefixes are removed.Pre-Review Checklist
[shared_preferences]pubspec.yamlwith an appropriate new version according to the pub versioning philosophy, or I have commented below to indicate which version change exemption this PR falls under1.CHANGELOG.mdto add a description of the change, following repository CHANGELOG style, or I have commented below to indicate which CHANGELOG exemption this PR falls under1.///).If you need help, consider asking for advice on the #hackers-new channel on Discord.
Note: The Flutter team is currently trialing the use of Gemini Code Assist for GitHub. Comments from the
gemini-code-assistbot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed.Footnotes
Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling. ↩ ↩2 ↩3