Conversation
Made-with: Cursor
Resolves Connection type mismatch in downstream plugin-deploy-retrieve CI where duplicate @salesforce/core copies caused TS2322 errors on the usernameOrConnection property. Made-with: Cursor
bpbuch
approved these changes
Mar 11, 2026
jfeingold35
reviewed
Mar 11, 2026
| const deployId = asyncResult.jsonOutput!.result.id; | ||
|
|
||
| for (let attempt = 0; attempt < 40; attempt++) { | ||
| execSync('sleep 3'); |
Contributor
There was a problem hiding this comment.
Question: Is there a reason you're using execSync('sleep 3') instead of setTimeout(...., 3000) or setInterval(...., 3000)?
Collaborator
Author
There was a problem hiding this comment.
I needed synchronous blocking inside a synchronous test function. As far as I know setTimeout is async and would require converting the helper and all callers to async/await. That said, execSync('sleep 3') is ugly, agree :). Happy to refactor deployAndWait to be async with a promise-based delay instead. Will update.
Made-with: Cursor
jfeingold35
reviewed
Mar 11, 2026
Comment on lines
+44
to
+46
| const deployId = asyncResult.jsonOutput!.result.id; | ||
|
|
||
| for (let attempt = 0; attempt < 40; attempt++) { |
Contributor
There was a problem hiding this comment.
I was thinking that you'd have the logic of the project deploy report call within the callback for setTimeout(), but honestly, for a NUT, this is probably fine too.
jfeingold35
approved these changes
Mar 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
What issues does this PR fix or reference?
#, @W-21531714@
Functionality Before
Some files have < 80%
<insert gif and/or summary>
Functionality After
<insert gif and/or summary>