Conversation
…s any mandatory attributes when the suggestion is inserted. Also suggests attribute names when typing within a tag
…me for fetching configurations.
# Conflicts: # src/main/frontend/app/routes/builder/canvas/flow.tsx
…savebutton to sidebar
philipsens
reviewed
Nov 4, 2025
Member
philipsens
left a comment
philipsens
left a comment
There was a problem hiding this comment.
It took me a long time to understand some of the logic. I think this code can improve a lot in readability. It might be nice to do a little refactor together so you can see where I'm coming from.
|
@philipsens I've opened a new pull request, #117, to work on those changes. Once the pull request is ready, I'll request review from you. |
Contributor
Author
|
Applied the feedback, and I agree that I should chill with the nesting a bit 😄 Quick and easy to write, but difficult to decipher at times, even for my own code looking back at it a week later. |
philipsens
reviewed
Nov 11, 2025
…s not necessarily true, also removed the default tab
philipsens
approved these changes
Nov 20, 2025
VincentvanMedenbach
pushed a commit
that referenced
this pull request
Feb 11, 2026
* Attempt at autocompleting frankdoc elements * Editor now suggests frank-elements when opening a tag: '<' and inserts any mandatory attributes when the suggestion is inserted. Also suggests attribute names when typing within a tag * Doesnt show attribute suggestions when inside of quotation marks * Restructed backend and endpoints to now point to a projectname/filename for fetching configurations. * Can now update xmlcontent in memory * Fixed issue with sidebar close button not properly showing up, moved savebutton to sidebar * Applied feedback from review * Forgot two instances of assuming a project was loaded in when that was not necessarily true, also removed the default tab
VincentvanMedenbach
pushed a commit
that referenced
this pull request
Feb 11, 2026
* Attempt at autocompleting frankdoc elements * Editor now suggests frank-elements when opening a tag: '<' and inserts any mandatory attributes when the suggestion is inserted. Also suggests attribute names when typing within a tag * Doesnt show attribute suggestions when inside of quotation marks * Restructed backend and endpoints to now point to a projectname/filename for fetching configurations. * Can now update xmlcontent in memory * Fixed issue with sidebar close button not properly showing up, moved savebutton to sidebar * Applied feedback from review * Forgot two instances of assuming a project was loaded in when that was not necessarily true, also removed the default tab
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #110