Made api requests in the frontend more efficient#327
Merged
stijnpotters1 merged 2 commits intomasterfrom Mar 11, 2026
Merged
Conversation
Matthbo
reviewed
Mar 10, 2026
Member
Matthbo
left a comment
Matthbo
left a comment
There was a problem hiding this comment.
Seems to work way better and without issues, at least during my testing.
I did notice children of children always being null, which during code review is because of the shallow retrieval of the directory structure, this is completely okay.
Closing and then opening the parent directories didn't seem to rerequest the data, if this is because of the cached data maybe it's good to think about a cache time-to-live (TTL) which makes sure old cache isn't used.
If this is what we want, let's make that a new issue and PR.
src/main/frontend/app/components/file-structure/editor-data-provider.ts
Outdated
Show resolved
Hide resolved
stijnpotters1
force-pushed
the
fix/improved-request-handling
branch
from
0cf15d5 to
da967e5
Compare
|
Matthbo
approved these changes
Mar 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Now the frontend does not make duplicate api requests anymore
@Matthbo You can checkout in this branch and check how requests are made after the changes. If you have any feedback about additional improvements that could be made, let me know!