[Repo Assist] eng: update FSharp.TypeProviders.SDK to latest master (75ac6119)#1741
Draft
github-actions[bot] wants to merge 2 commits intomainfrom
Draft
[Repo Assist] eng: update FSharp.TypeProviders.SDK to latest master (75ac6119)#1741github-actions[bot] wants to merge 2 commits intomainfrom
github-actions[bot] wants to merge 2 commits intomainfrom
Conversation
Updates paket.lock to FSharp.TypeProviders.SDK commit 75ac6119 (previously ce34c1cc). New upstream changes since ce34c1cc: - Bug fix: ProvidedTypeDefinition.Logger was silently broken (created a fresh ref cell on every access, so Logger := Some f had no effect) - Bug fix: 5 new tests for Logger warning and non-Int32 enum round-trips - Performance: ILFieldDefs/ILEventDefs/ILPropertyDefs converted to concrete classes with lazy O(1) name-lookup caches (mirrors ILMethodDefs) - Performance: save-based caching for GetField/GetEvent/GetNestedType in ProvidedTypeDefinition (consistent with GetMethodImpl/GetPropertyImpl) - Performance: ILNestedExportedTypesAndForwarders: Map -> Dictionary for O(1) Also regenerates AssemblyInfo files to match current version (8.1.8.0). Build: 0 errors, 26 warnings (pre-existing) Tests: 2920 passed, 0 failed Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🤖 This is an automated pull request from Repo Assist, an AI assistant for this repository.
Summary
Updates
paket.lockto pinFSharp.TypeProviders.SDKto the latest master commit75ac6119(previouslyce34c1cc).Changes in upstream TypeProviders.SDK
The new commits since
ce34c1ccinclude:Bug fixes
ProvidedTypeDefinition.Loggerwas silently broken (PR Review request default encoding #501): the staticLoggermember created a freshrefcell on every access, soProvidedTypeDefinition.Logger := Some fwrote into a temporary that was immediately discarded. The all-static-parameters-optional warning (and any custom logger) could never fire. Fixed by storing the ref in astatic let loggerReffield.Performance improvements
ILFieldDefs,ILEventDefs,ILPropertyDefs(PR Update ja/library/Http.fsx following changes of the original document. #502): converted from abstract interfaces to concrete classes with lazyDictionaryname-index caches, mirroring the existingILMethodDefspattern.GetField/GetPropertyImpl/GetEventinTypeSymbolandTargetTypeDefinitionnow useTryFindByNameinstead ofArray.tryFind(O(n)).save-based caching forGetField/GetEvent/GetNestedType(PR Add AppVeyor CI #498): consistent withGetMethodImpl/GetPropertyImpl.ILNestedExportedTypesAndForwarders:Map→Dictionaryfor O(1) lookups (PR Add AppVeyor CI #498).Also included
Regenerated
AssemblyInfo*.fsto match the current version (8.1.8.0) — the on-disk files were stale at 8.1.0.0.Test Status
dotnet run --project build/build.fsproj -t Build— 0 errors, 26 warnings (pre-existing)dotnet test tests/FSharp.Data.Core.Tests/— 2920 passed, 0 failed