removed SignRat function, called SignInt instead#10
Open
cdwensley wants to merge 1 commit intogap-packages:masterfrom
Open
removed SignRat function, called SignInt instead#10cdwensley wants to merge 1 commit intogap-packages:masterfrom
cdwensley wants to merge 1 commit intogap-packages:masterfrom
Conversation
Author
|
It was previously the case that tests failed with stable-4.10 and stable-4.9, so all seems well? |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #10 +/- ##
==========================================
+ Coverage 42.72% 42.79% +0.07%
==========================================
Files 27 27
Lines 2928 2916 -12
==========================================
- Hits 1251 1248 -3
+ Misses 1677 1668 -9
🚀 New features to boost your workflow:
|
Member
|
Oops this PR was overlooked :-( It seems the hap shipped in GAP 4.12 still uses So we can either drop 4.12 from the CI; or just keep providing a thin wrapper (basically make |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is part of the process of dealing with GAP issue #5191.
Now that SignRat has been replaced by SignInt in HAP, we can remove the declaration and method for SignRat in HAPcryst, and replace calls to SignRat by SignInt. Once this PR is merged we can proceed to work on a Sign function for the main GAP library, and maybe reintroduce a SignRat function there.
Once again I am getting a host of errors when running HAPcryst.tst on my system, so I shall be interested to see what happens when this PR proposal is tested.