Make Input and Title Screen Unbricked Consistent with other Folders #149
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed in #137 (comment) the Input folder of unbricked has an
input.asmfile that is unused and copied into themain.asm. This pull request removes this file and makes the code indentation more consistent (see #83 (comment)). In addition to this, this PR makes the Title Screen folder consistent with the rest of the tutorial by not includinginput.asmin its build script, and by placing the code in itsmain.asminstead. This should make the build scripts easy for a beginner to read.Alternatively we could introduce linking multiple assembly files in the title screen section as I see the serial link tutorial is doing now. Since the serial link tutorial is rather dense and the title screen is sparse maybe front-loading linking multiple files together could be beneficial?
Let me know what you think. If we want to leave it up to serial link to introduce the additional linking concept, then this PR will do as is. If not I can open a new one where I refactor the tutorial slightly to introduce this earlier (e.g. remove it from serial link, add it to title screen).