fix(ci): generate JUnit XML to silence codecov-action warnings#300
Conversation
Semver Impact of This PR🟢 Patch (bug fixes) 📋 Changelog PreviewThis is how your changes will appear in the changelog. Bug Fixes 🐛
🤖 This preview updates automatically when you update the PR. |
Codecov Results 📊✅ 2071 passed | Total: 2071 | Pass Rate: 100% | Execution Time: 0ms All tests are passing successfully. ✅ Patch coverage is 100.00%. Project has 3607 uncovered lines. Coverage diff@@ Coverage Diff @@
## main #PR +/-##
==========================================
+ Coverage 76.42% 76.42% —%
==========================================
Files 117 117 —
Lines 15298 15298 —
Branches 0 0 —
==========================================
+ Hits 11691 11691 —
- Misses 3607 3607 —
- Partials 0 0 —Generated by Codecov Action |
BYK
force-pushed
the
fix/junit-xml-ci-warnings
branch
from
7d6b8c9 to
f13f2e6
Compare
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
| <!-- lore:019c91e0-6d82-7f46-916a-f1e6555b8175 --> | ||
| * **General coding preference**: Prefer explicit error handling over silent failures | ||
| <!-- lore:019c91e0-6ce0-740b-b448-9fa0f31fedaf --> | ||
| * **Code style**: User prefers no backwards-compat shims, fix callers directly |
There was a problem hiding this comment.
Duplicate preference entries added to AGENTS.md
Low Severity
Two preference entries are duplicated verbatim with different lore IDs. "General coding preference: Prefer explicit error handling over silent failures" appears on both lines 655 and 659, and "Code style: User prefers no backwards-compat shims, fix callers directly" appears on both lines 657 and 661. Since AGENTS.md is consumed as context by AI coding agents, redundant entries waste context window budget and add noise.
Additional Locations (1)
## Summary `getsentry/codecov-action@main` has `enable-tests: true` by default, searching for JUnit XML files matching `**/*.junit.xml`. Since the project produced no JUnit output, every CI run emitted 3 warnings about missing JUnit XML files. Bun's test runner natively supports JUnit XML via `bunfig.toml`, so enabling it is the cleanest fix — it also unlocks test result reporting (test counts, pass rate, test deltas vs base branch) in the codecov action for free. ## Changes - **`bunfig.toml`**: added `[test.reporter]` section with `junit = "test-results.junit.xml"` - **`.gitignore`**: added `*.junit.xml` under test artifacts so the generated file isn't accidentally committed No CI workflow changes needed — the codecov action's default glob `**/*.junit.xml` already matches the output path.
1 participant
Summary
getsentry/codecov-action@mainhasenable-tests: trueby default, searching for JUnit XML files matching**/*.junit.xml. Since the project produced no JUnit output, every CI run emitted 3 warnings about missing JUnit XML files.Bun's test runner natively supports JUnit XML via
bunfig.toml, so enabling it is the cleanest fix — it also unlocks test result reporting (test counts, pass rate, test deltas vs base branch) in the codecov action for free.Changes
bunfig.toml: added[test.reporter]section withjunit = "test-results.junit.xml".gitignore: added*.junit.xmlunder test artifacts so the generated file isn't accidentally committedNo CI workflow changes needed — the codecov action's default glob
**/*.junit.xmlalready matches the output path.