fix(nightly): push to GHCR from artifacts dir so layer titles are bare filenames#301
Merged
fix(nightly): push to GHCR from artifacts dir so layer titles are bare filenames#301
Conversation
…e filenames ORAS records file paths as layer title annotations verbatim. Pushing 'artifacts/*.gz' stored titles as 'artifacts/sentry-linux-x64.gz', but findLayerByFilename() searches for 'sentry-linux-x64.gz' (no prefix). Fix: use working-directory: artifacts so the glob expands to bare filenames like 'sentry-linux-x64.gz'.
Contributor
Semver Impact of This PR🟢 Patch (bug fixes) 📋 Changelog PreviewThis is how your changes will appear in the changelog. Bug Fixes 🐛
🤖 This preview updates automatically when you update the PR. |
Contributor
Codecov Results 📊✅ Patch coverage is 100.00%. Project has 3607 uncovered lines. Coverage diff@@ Coverage Diff @@
## main #PR +/-##
==========================================
+ Coverage 76.42% 76.42% —%
==========================================
Files 117 117 —
Lines 15298 15298 —
Branches 0 0 —
==========================================
+ Hits 11691 11691 —
- Misses 3607 3607 —
- Partials 0 0 —Generated by Codecov Action |
betegon
pushed a commit
that referenced
this pull request
Feb 26, 2026
…e filenames (#301) ## Summary - Fixes `Error: No nightly build found for sentry-linux-x64.gz` when running `sentry cli upgrade nightly` - Root cause: ORAS records file paths as OCI layer title annotations verbatim. Pushing `artifacts/*.gz` stored titles as `artifacts/sentry-linux-x64.gz`, but `findLayerByFilename()` in `src/lib/ghcr.ts` searches for `sentry-linux-x64.gz` (no directory prefix). - Fix: add `working-directory: artifacts` to the Push to GHCR step so the glob `*.gz` expands to bare filenames. **Before** (from the live GHCR manifest): ```json {"title": "artifacts/sentry-linux-x64.gz"} ``` **After**: ```json {"title": "sentry-linux-x64.gz"} ```
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Error: No nightly build found for sentry-linux-x64.gzwhen runningsentry cli upgrade nightlyartifacts/*.gzstored titles asartifacts/sentry-linux-x64.gz, butfindLayerByFilename()insrc/lib/ghcr.tssearches forsentry-linux-x64.gz(no directory prefix).working-directory: artifactsto the Push to GHCR step so the glob*.gzexpands to bare filenames.Before (from the live GHCR manifest):
{"title": "artifacts/sentry-linux-x64.gz"}After:
{"title": "sentry-linux-x64.gz"}