fix(node): Use context-scoped suppression for LangChain + AI provider span deduplication#19688
Draft
nicohrubec wants to merge 5 commits intodevelopfrom
Draft
fix(node): Use context-scoped suppression for LangChain + AI provider span deduplication#19688nicohrubec wants to merge 5 commits intodevelopfrom
nicohrubec wants to merge 5 commits intodevelopfrom
Conversation
Contributor
size-limit report 📦
|
Contributor
node-overhead report 🧳Note: This is a synthetic benchmark with a minimal express app and does not necessarily reflect the real-world performance impact in an application.
|
andreiborza
reviewed
Mar 12, 2026
Member
There was a problem hiding this comment.
This is great! Can you also please adapt https://github.com/getsentry/sentry-javascript/blob/develop/.agents/skills/add-ai-integration/SKILL.md to mention that lowest-level ai integrations have to check for suppression?
And also, we can add a rule to bugbot to specifically lint for this, see https://github.com/getsentry/sentry-javascript/blob/develop/.cursor/BUGBOT.md#auto-instrumentation-sdk-integrations-sentry-specific-conventions as an example.
Contributor
|
This pull request has gone three weeks without activity. In another week, I will close it. But! If you comment or otherwise update it, I will reset the clock, and if you apply the label |
Contributor
Semver Impact of This PR🟢 Patch (bug fixes) 📋 Changelog PreviewThis is how your changes will appear in the changelog. New Features ✨Bun
Core
Deno
Deps
Nestjs
Node
Nuxt
Other
Bug Fixes 🐛Ci
Cloudflare
Core
Deps
Hono
Nestjs
Nextjs
Node
Nuxt
Other
Documentation 📚New Release
Other
Internal Changes 🔧Browser
Changelog
Ci
Cloudflare
Core
Deps
Deps Dev
E2e
Lint
Nextjs
Nuxt
Other
Other
🤖 This preview updates automatically when you update the PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When both LangChain and an AI provider integration (OpenAI, Anthropic, Google GenAI) are active, a single LangChain invoke() call produces duplicate gen_ai.chat spans — one from LangChain's callback handler and one from the underlying provider instrumentation.
The previous fix globally disabled provider instrumentations when LangChain was detected, but this broke direct provider SDK calls unrelated to LangChain.
This PR sets a suppression flag on the current scope during LangChain invoke/stream/batch execution. Provider instrumentations check this flag and skip span creation if set.
Closes #19687